Skip to content

followup for #1203: deploy.json fix for src/common/* #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2023
Merged

followup for #1203: deploy.json fix for src/common/* #1245

merged 3 commits into from
Jul 27, 2023

Conversation

melange396
Copy link
Collaborator

hopefully this works to make github-deploy-repo catch all the files from src/common/ (#1203 added a file to src/common/covid_hosp/, and there are a total of 3 in that subdir now)

@melange396 melange396 requested review from korlaxxalrok and rzats July 25, 2023 22:10
@melange396 melange396 changed the base branch from dev to group/covid_hosp_auto_columns_2 July 25, 2023 22:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

korlaxxalrok
korlaxxalrok approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I am not 100% sure if recursive will do what we think it will do, but I suppose we need to try it to find out :)

@melange396
Copy link
Collaborator Author

I am not 100% sure if recursive will do what we think it will do

i think/hope it will? i cribbed it from some usages at the bottom of the same file, and a quick look at the source seems promising.

@melange396 melange396 merged commit 10b307b into group/covid_hosp_auto_columns_2 Jul 27, 2023
@melange396 melange396 deleted the 1203_deployjson_followup branch July 27, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlaxxalrok korlaxxalrok korlaxxalrok approved these changes

@rzats rzats Awaiting requested review from rzats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melange396 @korlaxxalrok