Skip to content

Add rvdss indicator/data source #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 64 commits into
base: dev
Choose a base branch
from
Draft

Add rvdss indicator/data source #1542

wants to merge 64 commits into from

Conversation

cchuong
Copy link
Collaborator

@cchuong cchuong commented Sep 13, 2024

Summary:

Code to create a new datasource for the epidata AP. The data is respiratory virus detections in Canada, reported by the Public Health Agency of Canada (PHAC).

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries self-requested a review September 13, 2024 19:44
@nmdefries
Copy link
Contributor

We also want to have some unit tests here. This can be complicated for functions that normally interact with external components (websites, databases, etc), but we want to at least test functions that don't require that. (External components can be faked with mocking packages, but it's not essential.)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
40.5% Duplication on New Code (required ≤ 20%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants