feat: add grpc to glossary #3551
Conversation
Signed-off-by: Animesh Pathak <[email protected]>
Sonichigo
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo,
nate-double-u,
Okabe-Junya and
hlipsig
as code owners
github-project-automation
bot
moved this to 📋 Backlog
in CNCF glossary definition review board
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Nice idea to add gRPC.
Can someone from the gRPC team review this? @gnossen @ejona86 @thisisnotapril
See inline comments.
/cc @nate-double-u
Co-authored-by: Patrice Chalin <[email protected]> Signed-off-by: Animesh Pathak <[email protected]>
Added a link to the gRPC website for reference. Signed-off-by: Animesh Pathak <[email protected]>
|
@chalin I have resolved the comments! @gnossen @ejona86 @thisisnotapril can I get feedback/suggestion on this PR? |
|
@iamNoah1 @nate-double-u can i get review? |
There was a problem hiding this comment.
@Sonichigo Thanks a lot for tackling this term and the effort you put in it. While it might be technically accurate I find it very complex to read. It references a lot of other technical terms, making it hard to understand for someone who is maybe not so much a technical person. Even if, it is not easy.
My encouragement is to double check on our styleguide: https://glossary.cncf.io/style-guide/ to understand how we want terms to be described ideally.
Please also pay attention to use semantic line breaks.
Describe your changes
This pull request adds a new conceptual documentation page for gRPC, covering its purpose, benefits, and use cases in modern distributed systems and microservices architectures.
content/en/grpc.mdto provide an overview of gRPC, including its architecture (HTTP/2, Protocol Buffers), the problems it solves in distributed systems, and its advantages for microservices, streaming, and interoperability.Related issue number or link (ex:
resolves #issue-number)resolves #1038
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".