Skip to content

Launcher language fixes #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fayeed wants to merge 6 commits into
base: dev
Choose a base branch
from
+5 −9
Open

Launcher language fixes #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50ffb0c
Trusted agent popup now works correctly
fayeed Feb 27, 2023
09294c7
Fixed language actions
fayeed Feb 27, 2023
8179e0a
Updated changelog
fayeed Feb 27, 2023
e1d6537
Change action button name
fayeed Mar 10, 2023
2090ee1
Merge branch 'dev' into launcher-language-fixes
fayeed Mar 10, 2023
ea5b6d4
Merge branch 'dev' into launcher-language-fixes
fayeed Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/src/components/Language.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const Language = (props: Props) => {
const installLanguage = async () => {
setLoading(true);
try {
if (languageBundlePath) {
if (languageHash) {
await client!.languages.byAddress(languageHash);

await getLanguages();
Expand Down Expand Up @@ -211,16 +211,16 @@ const Language = (props: Props) => {
<j-flex a="center" gap="200">
<j-button
variant="link"
onClick={() => setInstallLanguageModalOpen(false)}
onClick={() => setPublishLanguageModalOpen(false)}
>
Cancel
</j-button>
<j-button
variant="primary"
onClick={installLanguage}
onClick={publishLanguage}
Copy link
Contributor

@jdeepee jdeepee Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is for installing a language, it should not be calling publish right?

loading={loading}
>
Install
Publish
</j-button>
</j-flex>
</j-box>
Expand Down
6 changes: 1 addition & 5 deletions ui/src/components/TrustAgent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ const TrustAgent = (props: Props) => {
state: { client },
} = useContext(Ad4minContext);

const [opened, setOpened] = useState(false);

useEffect(() => {
setOpened(true);
}, []);
const [opened, setOpened] = useState(true);

const addTrustedAgent = async () => {
let agents = await client!.runtime.addTrustedAgents([props.candidate]);
Expand Down