Skip to content

Make link removal Prolog updates O(1) with retract #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucksus wants to merge 2 commits into
base: dev
Choose a base branch
from
+16 −2
Open

Make link removal Prolog updates O(1) with retract #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a054e93
Make link removals Prolog updates O(1) with retract
lucksus Mar 25, 2025
85d23d2
Merge branch 'dev' into feature/prolog-retract
jhweir Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rust-executor/src/perspectives/perspective_instance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,14 +1184,16 @@ impl PerspectiveInstance {
log::error!("Error spawning Prolog engine: {:?}", e)
};

let fact_rebuild_needed = !diff.removals.is_empty()
|| diff.additions.iter().any(|link| is_sdna_link(&link.data));
let fact_rebuild_needed = diff.additions.iter().any(|link| is_sdna_link(&link.data));

let did_update = if !fact_rebuild_needed {
let mut assertions: Vec<String> = Vec::new();
for addition in &diff.additions {
assertions.push(generic_link_fact("assert_link_and_triple", addition));
}
for removal in &diff.removals {
assertions.push(generic_link_fact("retract_link_and_triple", removal));
}

let query = format!("{}.", assertions.join(","));
match self_clone.prolog_query(query).await {
Expand Down
12 changes: 12 additions & 0 deletions rust-executor/src/perspectives/sdna.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,18 @@ url_decode_char(Char) --> [Char], { \+ member(Char, "%") }.
assert_link_and_triple(Source, Predicate, Target, Timestamp, Author) :-
(assert_link(Source, Predicate, Target, Timestamp, Author) ; true),
(assert_triple(Source, Predicate, Target) ; true).

retract_link(Source, Predicate, Target, Timestamp, Author) :-
link(Source, Predicate, Target, Timestamp, Author),
retract(link(Source, Predicate, Target, Timestamp, Author)).

retract_triple(Source, Predicate, Target) :-
triple(Source, Predicate, Target),
retract(triple(Source, Predicate, Target)).

retract_link_and_triple(Source, Predicate, Target, Timestamp, Author) :-
(retract_link(Source, Predicate, Target, Timestamp, Author) ; true),
(retract_triple(Source, Predicate, Target) ; true).
"#;
lines.extend(assert_link.split('\n').map(|s| s.to_string()));

Expand Down