Skip to content

Link language debugging #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucksus wants to merge 29 commits into
base: dev
Choose a base branch
from
+3,029 −1,165

workspace:* instead of link:../../core

da3dc3a
Select commit
Loading
Failed to load commit list.
Open

Link language debugging #611

workspace:* instead of link:../../core
da3dc3a
Select commit
Loading
Failed to load commit list.
Cursor / Cursor BugBot completed Jul 14, 2025 in 2m 35s

BugBot Review

BugBot Analysis Progress (3m 21s elapsed)

✅ Gathered PR context (45s)
✅ Analyzed code changes (3s)
✅ Completed bug detection — 2 potential bugs found (2m 31s)
✅ Validation and filtering completed (0s)
✅ Posted analysis results — 2 bugs reported (2s)
✅ Analysis completed successfully (0s)

Final Result: BugBot completed review and found 2 potential issues

Request ID: serverGenReqId_66a1d9aa-d7cf-4874-82a5-fe8c6701544b

Details

Bug: Language Association Logic Error

The logic for associating languages with perspectives was altered by removing the else clause that checked p.neighbourhood.meta.links for language references (where predicate is 'language' and target is the language address). This prevents languages used via meta links from being correctly identified as associated with perspectives, leading to them being incorrectly displayed as unused in the UI.

ui/src/components/Language.tsx#L87-L105

ad4m/ui/src/components/Language.tsx

Lines 87 to 105 in da3dc3a

const langs = await client!.languages.all();
const perspectives = await client!.perspective.all();
const tempLangs = [];
for (const lang of langs) {
const found = perspectives.find((p) => {
if (p.neighbourhood) {
if (p.neighbourhood.linkLanguage === lang.address) {
return true;
}
}
return false;
});
tempLangs.push({ language: lang, perspective: found });
}

Fix in Cursor • Fix in Web

Bug: Enum Case Change and Typo Bug

The PerspectiveState enum's string values were changed from SCREAMING_SNAKE_CASE (e.g., "PRIVATE") to PascalCase (e.g., "Private"), which is a breaking change for any code relying on the old string values. Additionally, the NeighboudhoodCreationInitiated enum value contains a typo ("Neighboudhood" instead of "Neighbourhood"), causing inconsistency with other enum values and the corresponding Rust enum.

core/src/perspectives/PerspectiveHandle.ts#L4-L11

ad4m/core/src/perspectives/PerspectiveHandle.ts

Lines 4 to 11 in da3dc3a

export enum PerspectiveState {
Private = "Private",
NeighboudhoodCreationInitiated = "NeighboudhoodCreationInitiated",
NeighbourhoodJoinInitiated = "NeighbourhoodJoinInitiated",
LinkLanguageFailedToInstall = "LinkLanguageFailedToInstall",
LinkLanguageInstalledButNotSynced = "LinkLanguageInstalledButNotSynced",
Synced = "Synced",
}

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

View more details on Cursor