Migration to Patternfly v6 #21611
Migration to Patternfly v6 #21611
Conversation
jelly
added
the
no-test
pkg/apps/application-list.jsx
Outdated
| @@ -150,17 +150,17 @@ export const ApplicationList = ({ metainfo_db, appProgress, appProgressTitle, ac | |||
| } else { | |||
| refresh_progress = null; | |||
| refresh_button = ( | |||
| <Button variant="secondary" onClick={refresh} id="refresh" aria-label={ _("Update package information") }> | |||
| <RebootingIcon /> | |||
| <Button icon={<RebootingIcon />} variant="secondary" onClick={refresh} id="refresh" aria-label={_("Update package information")}> | |||
There was a problem hiding this comment.
You mentioned that this is just a stylistic thing, as there are tons of changes regarding to PF6 I think it makes sense to keep this codemod turned off
There was a problem hiding this comment.
Agreed, I'll find the culprit and update the command ran in the description. I ran a test to see what exactly changes visually but found nothing
There was a problem hiding this comment.
Well there is a small margin but that's fine IMO
There was a problem hiding this comment.
Removed from codemods for now and commit updated
| <Toolbar className="ct-alert-toolbar"> | ||
| <ToolbarContent> | ||
| <ToolbarGroup spaceItems={{ default: "spaceItemsMd" }}> |
There was a problem hiding this comment.
So this no longer does any layout, what replaces this?
There was a problem hiding this comment.
IIRC I changed this after messing about with the wrap issue. Can check soon
|
|
||
| // REVIEW @Venefilyn: Is this still true? | ||
| /* Import our own fonts since the PF4 font-face rules are filtered out in build.js */ |
There was a problem hiding this comment.
This is a good first prio target :)
| </Text> | ||
| </TextContent> | ||
| </Content> | ||
| </Content> |
There was a problem hiding this comment.
This still exists? https://www.patternfly.org/components/text/#textcontent
There was a problem hiding this comment.
That's a v5 component and not in v6. Somehow the link albeit removed is still there showing v5 stuff. After the discussion on Matrix on Friday about it I've created upstream issues about it
Venefilyn
force-pushed
the
pf6
branch
2 times, most recently
from
243148a to
4bc7573
Compare
TODO: Add documentation about this
`npx @patternfly/class-name-updater ./pkg --v6 --fix`
WIP while we work through what can be skipped, what can be improved before merging, and what is fine to merge
To redo codemod simply reset the commit, revert changes you don't want, and run
button-moveIcons-icon-propis excluded as it only makes it have a small margin (can be added later)menuToggle-warn-iconOnly-togglesame as above icon exclusionhelperTextItem-warn-screenReaderText-updateis excluded for now as things should work still for most casesItems fixed or documented
When we are about to merge these should all be on our minds so we can fix either in this or preferably in upcoming PRs
<Content>, need to be verified manually post-merge TextContent + Text results in two Content components patternfly/pf-codemods#825@patternfly/patternfly/*-theme-dark.cssstuff is removed due to PF Tokensreminstead--pf-v5-global--spacer--need to be renamed to--pf-t--global--spacer--EmptyStateIconPropsandEmptyStateHeaderPropsare merged intoEmptyStatePropsiframesusePagecomponent as it should but we need an override to prevent whitespace in its grid Page - Allow main grid without sidebar and masthead patternfly/patternfly#7357--pf-t--global--icon--color--status--info--defaultAll new upstream issues deriving from this upgrade
Related PRs