Remove workaround for empty LEGAL.txt files, remove obsolete ABRT/reportd support #21629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanw/esbuild#3670 was fixed in esbuild 0.25.
We stopped releasing and testing on Fedora 39/40, so we don't need the special cases any more. Fedora 40 was the last OS which still had ABRT, so all the tests and mocking machinery can go.
Fedora 40 was the last OS which still had reportd, and we stopped releasing and testing there.
martinpitt
requested review from
allisonkarlitskaya and
jelly
and removed request for
allisonkarlitskaya
allisonkarlitskaya
approved these changes
Feb 17, 2025
| @@ -176,7 +176,7 @@ You can set these environment variables to configure the test suite: | |||
| * `TEST_OS`: The OS to run the tests in, like "fedora-coreos" or | |||
| "debian-stable". See the "cockpit-project/cockpit" section in the | |||
| [test map](https://github.com/cockpit-project/bots/blob/main/lib/testmap.py) | |||
| for all supported values. "fedora-40" is the default (`TEST_OS_DEFAULT` in | |||
There was a problem hiding this comment.
I guess that's a separate commit, but meh
Not much, other than I started with cleaning up the tests, and then realized we can clean up the ABRT stuff as well. If you prefer, I can squash them and do a quick no-test re-run. |
jelly
approved these changes
Feb 17, 2025
martinpitt
added a commit
to martinpitt/bots
that referenced
this pull request
Feb 17, 2025
cockpit-project/cockpit#21629 dropped the need for these.
1 task
|
@jelly Yes, thanks for pointing out: cockpit-project/bots#7449 |
martinpitt
added a commit
to cockpit-project/bots
that referenced
this pull request
Feb 18, 2025
cockpit-project/cockpit#21629 dropped the need for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.