Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base1: extend dirname test cases with relative paths #21633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

base1: extend dirname test cases with relative paths #21633

wants to merge 1 commit into from

Conversation

jelly
Copy link
Member

@jelly jelly commented Feb 18, 2025

No description provided.

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Feb 18, 2025
@jelly jelly requested a review from mvollmer February 18, 2025 09:58
mvollmer
mvollmer approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One terminology nitpick: having ".." in a pathname does not make it relative. A relative pathname is one that doesn't start with a "/". We could call these "not normalized" or "not canonical", maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvollmer mvollmer mvollmer approved these changes

Assignees
No one assigned
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @mvollmer