Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testlib: Workaound mysterious disappearing buttons #21635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvollmer
Copy link
Member

No description provided.

@mvollmer mvollmer added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Feb 20, 2025
@mvollmer
Copy link
Member Author

@martinpitt, @jelly, fyi. This is magic...

@mvollmer mvollmer force-pushed the test-take-two-screenshots branch from dff4682 to 498d8da Compare February 20, 2025 11:43
@mvollmer
Copy link
Member Author

Ok, this shows how the button went from white to blue just by taking the second screenshot. (The "reference image" in this run is the first screenshot, the "new pixels" are the second screenshot.

This is just the page actually changing from one to the other, in parts that are normally ignored. (The plots and IO rate in this case)

So maybe we shouldn't loudly warn if the two screenshots are different.

@mvollmer
Copy link
Member Author

This shows the same in cockpit-files. The second screenshot has the blue background, the first is white.

@mvollmer mvollmer removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Feb 20, 2025
@mvollmer mvollmer force-pushed the test-take-two-screenshots branch from 498d8da to 18bd608 Compare February 20, 2025 13:05
@mvollmer mvollmer marked this pull request as ready for review February 20, 2025 13:13
@mvollmer mvollmer requested a review from martinpitt February 20, 2025 13:13
@mvollmer
Copy link
Member Author

@martinpitt, this mysteriously seems to work... It gets rid of the SuperUser-testBasic disappearing button flake, and the TestFiles.testPermissions one.

@martinpitt
Copy link
Member

Wow, what a hack.. I am worried though about making all screenshots twice, that's quite some overhead? Could we perhaps hide that under some chromium_hack=False option and only enable it for the two problematic cases? Then at least we retain something greppable, and avoid that this bug happens more often/in more situations.

@mvollmer
Copy link
Member Author

Could we perhaps hide that under some chromium_hack=False option and only enable it for the two problematic cases?

Yes, certainly.

@mvollmer mvollmer force-pushed the test-take-two-screenshots branch from 18bd608 to be92ecb Compare February 20, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants