-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testlib: Workaound mysterious disappearing buttons #21635
base: main
Are you sure you want to change the base?
Conversation
@martinpitt, @jelly, fyi. This is magic... |
dff4682
to
498d8da
Compare
Ok, this shows how the button went from white to blue just by taking the second screenshot. (The "reference image" in this run is the first screenshot, the "new pixels" are the second screenshot. This is just the page actually changing from one to the other, in parts that are normally ignored. (The plots and IO rate in this case) So maybe we shouldn't loudly warn if the two screenshots are different. |
This shows the same in cockpit-files. The second screenshot has the blue background, the first is white. |
498d8da
to
18bd608
Compare
@martinpitt, this mysteriously seems to work... It gets rid of the SuperUser-testBasic disappearing button flake, and the TestFiles.testPermissions one. |
Wow, what a hack.. I am worried though about making all screenshots twice, that's quite some overhead? Could we perhaps hide that under some |
Yes, certainly. |
18bd608
to
be92ecb
Compare
No description provided.