Skip to content

[CNSL-1935] Add automated release PR workflow - #95

Merged
linhcrl merged 2 commits into
mainfrom
version-bump-workflow
May 15, 2026
Merged

[CNSL-1935] Add automated release PR workflow#95
linhcrl merged 2 commits into
mainfrom
version-bump-workflow

Conversation

@linhcrl

@linhcrl linhcrl commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Added GitHub Actions workflow that automatically creates release PRs when automation/pending-deploy-* branches are merged to main. The workflow updates go.mod and main.go for major version changes, updates config.yaml with the new version, and regenerates the OpenAPI client to automatically update all generated files (README.md, docs/README.md, pkg/client/configuration.go, and other generated code).

Example PR: https://github.com/cockroachlabs/cockroach-cloud-sdk-go-automation-testing/pull/185

@linhcrl linhcrl changed the title Add version bump workflow [CNSL-1935] Add version bump workflow Mar 29, 2026
@linhcrl
linhcrl force-pushed the version-bump-workflow branch from 242ab7f to 8ee0006 Compare March 29, 2026 07:50
@linhcrl

linhcrl commented Mar 29, 2026

Copy link
Copy Markdown
Contributor Author

Tested this locally and it worked as expected

@linhcrl linhcrl changed the title [CNSL-1935] Add version bump workflow DO NOT MERGE - [CNSL-1935] Add version bump workflow Mar 29, 2026
Comment thread .github/workflows/finalize-release.yml Outdated
Comment thread .github/workflows/finalize-release.yml Outdated
Comment thread .github/workflows/finalize-release.yml Outdated
Comment thread .github/workflows/finalize-release.yml Outdated
Comment thread internal/update-version.sh Outdated
Comment thread internal/update-version.sh Outdated
@linhcrl
linhcrl marked this pull request as draft March 31, 2026 08:10
@linhcrl linhcrl changed the title DO NOT MERGE - [CNSL-1935] Add version bump workflow [CNSL-1935] Add version bump workflow Mar 31, 2026
@linhcrl
linhcrl force-pushed the version-bump-workflow branch from 8ee0006 to f99ec07 Compare March 31, 2026 22:43
@github-actions

Copy link
Copy Markdown

No breaking changes detected.

@linhcrl
linhcrl force-pushed the version-bump-workflow branch 8 times, most recently from c389a70 to b1e2713 Compare April 5, 2026 07:11
@linhcrl linhcrl changed the title [CNSL-1935] Add version bump workflow [CNSL-1935] Add automated release PR workflow Apr 5, 2026
@linhcrl linhcrl changed the title [CNSL-1935] Add automated release PR workflow DO NOT MERGE - [CNSL-1935] Add automated release PR workflow Apr 5, 2026
@linhcrl
linhcrl marked this pull request as ready for review April 7, 2026 15:29
@linhcrl
linhcrl force-pushed the version-bump-workflow branch 3 times, most recently from a96edc4 to fc74aa3 Compare April 13, 2026 15:37
@linhcrl
linhcrl force-pushed the version-bump-workflow branch from fc74aa3 to de23fd1 Compare April 29, 2026 01:25
@linhcrl linhcrl changed the title DO NOT MERGE - [CNSL-1935] Add automated release PR workflow Add automated release PR workflow Apr 29, 2026
@linhcrl linhcrl changed the title Add automated release PR workflow [CNSL-1935] Add automated release PR workflow Apr 29, 2026
@linhcrl
linhcrl requested a review from fantapop April 29, 2026 03:27
@linhcrl
linhcrl force-pushed the version-bump-workflow branch from de23fd1 to 67ffaf4 Compare April 29, 2026 03:40
@fantapop

fantapop commented May 1, 2026

Copy link
Copy Markdown
Contributor

thanks for including the sample images. I noticed that the Changelog entries are extremely long. I think we'll want to experiment with the prompt we're using to build those.

Comment thread internal/update_version.sh Outdated
Comment thread internal/update-version.sh Outdated
@linhcrl
linhcrl force-pushed the version-bump-workflow branch 3 times, most recently from cf22100 to 26a06db Compare May 1, 2026 20:48
@linhcrl
linhcrl requested a review from fantapop May 1, 2026 20:53
@linhcrl
linhcrl force-pushed the version-bump-workflow branch from 26a06db to 4b5eccc Compare May 1, 2026 21:00
@linhcrl

linhcrl commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

@fantapop I've updated the reusable action to remove changelog entries from the commit message body.

Why: Commit message lines should be at most 72 characters, but changelog entries don't follow this rule. It would be unnecessarily complex to convert the changelog entries to wrap at 72 characters for the commit message. Since the individual commits already describe the changes and the changelog entries are visible in the PR description, the simpler approach is to use a hardcoded message format.

Here's the PR: cockroachdb/actions#27

@linhcrl
linhcrl force-pushed the version-bump-workflow branch 4 times, most recently from f49c201 to 5ec108f Compare May 1, 2026 23:48
@fantapop

fantapop commented May 2, 2026

Copy link
Copy Markdown
Contributor

yeah makes sense. I didn't think it was coming from this PR. It just looked long and agent generated. You hand crafted it though?

I did use claude to write it. It's the changelog entry for this PR. I'was just trying to say it's not autogenerated by a workflow based on any prompt. I can update the relevant PR to make the entry shorter but it's a one off

ah I see. makes sense. we are planning to generate the changelog entry from claude though right? We should consider asking it to keep it brief.

@linhcrl
linhcrl force-pushed the version-bump-workflow branch from 5ec108f to 03ec431 Compare May 4, 2026 22:33

@fantapop fantapop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. It seems like we could get away with logging to stdout for info lines and stderr for warn and error lines.

Comment thread scripts/lib/logging.sh Outdated
@linhcrl
linhcrl force-pushed the version-bump-workflow branch 10 times, most recently from 1b769d7 to 66e1e8d Compare May 12, 2026 15:21
@linhcrl
linhcrl force-pushed the version-bump-workflow branch 2 times, most recently from d5c9d25 to 1ac8e8d Compare May 15, 2026 07:24
Added GitHub Actions workflow that automatically creates release PRs
when automation/pending-deploy-* branches are merged to main. The
workflow updates go.mod and main.go for major version changes, updates
config.yaml with the new version, and regenerates the OpenAPI client to
automatically update all generated files (README.md, docs/README.md,
pkg/client/configuration.go, and other generated code).

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@linhcrl
linhcrl force-pushed the version-bump-workflow branch from 1ac8e8d to 70da10e Compare May 15, 2026 15:33
@linhcrl
linhcrl merged commit edefefe into main May 15, 2026
1 check passed
@linhcrl
linhcrl deleted the version-bump-workflow branch May 15, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants