explain: hide contention time when it's zero #143659
Conversation
|
This change is |
This commit updates the EXPLAIN logic to hide `KV contention time`, `KV lock wait time`, and `KV latch wait time` fields if they are zero (either because there was no contention or because there was but very short so that it was rounded down to 0µs). Note that we still will include the top-level "contention time" information. Release note: None
yuzefovich
force-pushed
the
explain-cleanup
branch
4 times, most recently
from
0961959 to
d4e18c8
Compare
yuzefovich
changed the title
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball)
-- commits line 4 at r2:
I wonder whether we should still show zero contention information in VERBOSE mode, thoughts? I'm leaning towards not showing to make existing output more useful (I think we could apply the same rationale for hiding zeroes to some other things, e.g. "max sql temp disk usage").
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
Previously, yuzefovich (Yahor Yuzefovich) wrote…
I wonder whether we should still show zero contention information in VERBOSE mode, thoughts? I'm leaning towards not showing to make existing output more useful (I think we could apply the same rationale for hiding zeroes to some other things, e.g. "max sql temp disk usage").
Not showing even in VERBOSE mode SGTM.
This commit updates the EXPLAIN logic to hide
KV contention time,KV lock wait time, andKV latch wait timefields if they are zero (either because there was no contention or because there was but very short so that it was rounded down to 0µs).Note that we still will include the top-level "contention time" information.
Epic: None
Release note: None