roachprod: make port expanders work with virtual clusters #150514
Merged
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the pgport and uiport expanders would cache results for already discovered ports. However, this cache did not keep track of which virtual cluster the ports were for. This changes the expander to do so, similar to pgurl.
DarrylWong
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
herkolategan
approved these changes
Jul 28, 2025
golgeek
approved these changes
Jul 29, 2025
|
TFTRs! bors r=herkolategan,golgeek |
craig bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
149374: changefeedccl: add pts management performance benchmark r=andyyang890 a=aerfrei This change adds benchmarking for the behavior of the protected timestamp system. The benchmark is a roachtest that creates 200 instances of the tpcc workload and starts a changefeed watching their 200 order tables for 45 minutes. We will use this same test to measure the performance of the pts system for multi-table feeds once they create a distinct pts record for each watched table. Epic: CRDB-1421 Fixes: #147781 Release note: None 150514: roachprod: make port expanders work with virtual clusters r=herkolategan,golgeek a=DarrylWong Previously the pgport and uiport expanders would cache results for already discovered ports. However, this cache did not keep track of which virtual cluster the ports were for. This changes the expander to do so, similar to pgurl. Release note: none Epic: none Fixes: none 150871: application_api: Fix TestHotRanges2Response r=kyle-a-wong a=kyle-a-wong Test asserted that the hot ranges response was ordered by CPUTimePerSecond descending, but its actually ascending. Also unskips the test Epic: None Release note: None Co-authored-by: Aerin Freilich <[email protected]> Co-authored-by: DarrylWong <[email protected]> Co-authored-by: Kyle Wong <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the pgport and uiport expanders would cache results for already discovered ports. However, this cache did not keep track of which virtual cluster the ports were for. This changes the expander to do so, similar to pgurl.
Release note: none
Epic: none
Fixes: none