roachtest: do not build arm64 and fips if probabilitiy is 0 #157158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies are 0 Previously, even when the probabilities for arm64 and fips builds were set to 0, the nightly roachtest script would still build those variants, which is unnecessary and wasteful. This change modifies the script to skip building arm64 and fips variants when their respective probabilities are set to 0. Epic: none Release note: none
rail
added
C-enhancement
Member
|
This change is |
rail
requested review from
a team,
DarrylWong,
golgeek and
srosenberg
and removed request for
a team
DarrylWong
approved these changes
Nov 12, 2025
Contributor
DarrylWong
left a comment
DarrylWong
left a comment
There was a problem hiding this comment.
This seems like a fine optimization to make, although I imagine only a very small percentage of runs even touch the default probabilities.
Contributor
|
Oh I see, I didn't realize the pgo script called the nightly script. SGTM then! |
Member
Author
yeah, it saves almost 2 hours there (building twice). |
Member
Author
|
bors r=DarrylWong |
craig bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
155872: changefeedccl: fix timestamp for desc fetches during planning r=andyyang890,aerfrei a=log-head When a changefeed is planned and executed, there are several places where target table descriptors are fetched. With a db-level changefeed, the set of tables can change during changefeed startup. Now, the timestamp is set to the schema timestamp for retrieving table descriptors. Adding a schema_ts to the protobuf for ChangeAggregatorSpec and ChangeFrontierSpec. Fixes: #154549 Epic: CRDB-1421 Release note: None 157144: sql: add `ALTER TABLE ... SET/ADD IDENTITY` to the declarative schema… r=shghasemi a=shghasemi … changer This change adds support for `ALTER TABLE ... SET/ADD IDENTITY` to the declarative schema changer. This schema change operation runs using the legacy schema changer in versions older than 26.1. Epic: CRDB-31283 Fixes #142918 Release note (sql change): `ALTER TABLE ... SET/ADD GENERATED AS IDENTITY` is supported by the declerative schema changer in 26.1 or later. 157158: roachtest: do not build arm64 and fips if probabilitiy is 0 r=DarrylWong a=rail Previously, even when the probabilities for arm64 and fips builds were set to 0, the nightly roachtest script would still build those variants, which is unnecessary. This change modifies the script to skip building arm64 and fips variants when their respective probabilities are set to 0. Epic: none Release note: none Co-authored-by: Matthew Lougheed <[email protected]> Co-authored-by: Shadi Ghasemitaheri <[email protected]> Co-authored-by: Rail Aliiev <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
golgeek
added a commit
to golgeek/cockroach
that referenced
this pull request
Nov 13, 2025
PR cockroachdb#157158 introduced a conditional build for ARM64 and FIPS architectures based on the metamorphic probability flags. The initial implementation used `bc` to compare floating point, but the command is not available on the TeamCity agents. This patch uses `awk` in place of `bc`. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
157759: roachtest: fix conditional build for arm64 and fips r=herkolategan a=golgeek PR #157158 introduced a conditional build for ARM64 and FIPS architectures based on the metamorphic probability flags. The initial implementation used `bc` to compare floating point, but the command is not available on the TeamCity agents: ``` build/teamcity/cockroach/nightlies/roachtest_nightly_impl.sh: line 39: bc: command not found ``` This patch uses `awk` in place of `bc`. Epic: none Release note: None Co-authored-by: Ludovic Leroux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even when the probabilities for arm64 and fips builds were set to 0, the nightly roachtest script would still build those variants, which is unnecessary. This change modifies the script to skip building arm64 and fips variants when their respective probabilities are set to 0.
Epic: none
Release note: none