Added preview notice and backported to missing versions #21194
Conversation
Added preview notice and backported to missing versions
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmloveland
left a comment
rmloveland
left a comment
There was a problem hiding this comment.
LGTM except that we historically also add stuff in preview to the 'feature availability' page under a heading with brief description (see my comment for link to it and more details)
also the build is not green but i can't tell why, build log looks odd. maybe will be resolved on next push idk
| docs_area: manage | ||
| --- | ||
|
|
||
| {{site.data.alerts.callout_info}} |
There was a problem hiding this comment.
historically we also create an entry for each thing that is in preview status on the CockroachDB Feature Availability page. I should have mentioned that in the review on #20502 but failed to, sorry about that
Could even just be like one heading with one sentence (see the LTREE one)
There was a problem hiding this comment.
Ok thanks will do! And yeah not sure what's wrong with the build, hoping it turns out to just be a blip.
There was a problem hiding this comment.
Turns out there was already a mention of this feature there- I think Kathryn added it but didn't write a more comprehensive doc at the time. Regardless, I made a couple of small changes to that must mostly left it as is. Hoping the build issue was related to the github outage that just now seems to have resolved.
There was a problem hiding this comment.
Update to that- it does look like the reason for failing build is that they can't access github, which makes sense. The outage is fixed for me but seems to be still affecting the build- might have to just wait for tomorrow
Changed language in feature availability page
peachdawnleach
deleted the
20251118-doc-15438-read-from-standby-preview
branch
2 participants
Fixes: DOC-15438
Added preview notice and backported to missing versions