Skip to content

Fix XSS in side panel via unescaped server data (#245) #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boot-coco wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix XSS in side panel via unescaped server data (#245) #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c581693
fix: escape server data in side panel innerHTML to prevent XSS (#245)
boot-coco Mar 9, 2026
0c57905
fix: add app_id scope check to V1 API handlers (#244)
boot-coco Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions extension/sidepanel/panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ async function loadItems(skipCache = false) {
updateCounts();
renderItems();
} catch (err) {
itemsContainer.innerHTML = `<div class="error-msg">${err.message}</div>`;
itemsContainer.innerHTML = `<div class="error-msg">${escapeHtml(err.message)}</div>`;
}
}

Expand All @@ -134,7 +134,7 @@ async function loadThread(itemId) {
renderThread(response);
showThreadView();
} catch (err) {
threadMessages.innerHTML = `<div class="error-msg">${err.message}</div>`;
threadMessages.innerHTML = `<div class="error-msg">${escapeHtml(err.message)}</div>`;
}
}

Expand Down Expand Up @@ -191,18 +191,18 @@ function renderItems() {
const sourceHost = item.source_url ? (() => { try { return new URL(item.source_url).hostname; } catch { return ''; } })() : '';

return `
<div class="item-card" data-id="${item.id}">
<div class="item-card" data-id="${escapeHtml(String(item.id))}">
<div class="item-header">
<span class="item-type ${item.type}">${item.type}</span>
${item.priority !== 'normal' ? `<span class="item-priority ${priorityClass}">${item.priority}</span>` : ''}
<span class="item-priority">${item.status}</span>
<span class="item-type ${escapeHtml(item.type)}">${escapeHtml(item.type)}</span>
${item.priority !== 'normal' ? `<span class="item-priority ${priorityClass}">${escapeHtml(item.priority)}</span>` : ''}
<span class="item-priority">${escapeHtml(item.status)}</span>
</div>
${item.title ? `<div class="item-title">${escapeHtml(item.title)}</div>` : ''}
${item.quote ? `<div class="item-quote">${escapeHtml(item.quote)}</div>` : ''}
${sourceHost ? `<div class="item-source" title="${escapeHtml(item.source_url)}"><span class="source-icon">\ud83d\udcc4</span> ${escapeHtml(item.source_title || sourceHost)}</div>` : ''}
${renderDispatchBadges(item.dispatches)}
<div class="item-meta">
<span>${item.created_by}</span>
<span>${escapeHtml(item.created_by)}</span>
<span>${time}</span>
</div>
${tags.length > 0 ? `<div class="item-tags">${tags.map(t => `<span class="tag">${escapeHtml(t)}</span>`).join('')}</div>` : ''}
Expand All @@ -224,8 +224,8 @@ function renderThread(item) {
threadHeader.innerHTML = `
<div class="item-card" style="cursor:default;margin-bottom:0;">
<div class="item-header">
<span class="item-type ${item.type}">${item.type}</span>
<span class="item-priority">${item.status}</span>
<span class="item-type ${escapeHtml(item.type)}">${escapeHtml(item.type)}</span>
<span class="item-priority">${escapeHtml(item.status)}</span>
</div>
${item.title ? `<div class="item-title">${escapeHtml(item.title)}</div>` : ''}
${item.quote ? `<div class="item-quote">${escapeHtml(item.quote)}</div>` : ''}
Expand Down Expand Up @@ -302,7 +302,7 @@ function formatTime(isoString) {

function escapeHtml(str) {
if (!str) return '';
return str.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
return str.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;').replace(/'/g, '&#39;');
}

// ------------------------------------------------------------------ dispatch display (#115)
Expand Down
34 changes: 34 additions & 0 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,9 @@ function handleGetItems(req, res) {
function handleGetItem(req, res) {
const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
res.json(item);
}

Expand Down Expand Up @@ -635,6 +638,9 @@ function handleAddMessage(req, res) {

const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}

const result = itemsDb.addMessage({
item_id: req.params.id,
Expand All @@ -650,6 +656,11 @@ function handleAddMessage(req, res) {
function handleAssignItem(req, res) {
const { assignee } = req.body;
if (!assignee) return res.status(400).json({ error: 'Missing assignee' });
const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const result = itemsDb.assignItem(req.params.id, assignee);
if (!result.changes) return res.status(404).json({ error: 'Item not found' });
sendWebhook('item.assigned', { id: req.params.id, assignee });
Expand All @@ -658,6 +669,11 @@ function handleAssignItem(req, res) {

// -- POST /items/:id/resolve
function handleResolveItem(req, res) {
const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const result = itemsDb.resolveItem(req.params.id);
if (!result.changes) return res.status(404).json({ error: 'Item not found' });
sendWebhook('item.resolved', { id: req.params.id });
Expand All @@ -666,20 +682,35 @@ function handleResolveItem(req, res) {

// -- POST /items/:id/verify
function handleVerifyItem(req, res) {
const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const result = itemsDb.verifyItem(req.params.id);
if (!result.changes) return res.status(404).json({ error: 'Item not found' });
res.json({ success: true });
}

// -- POST /items/:id/reopen
function handleReopenItem(req, res) {
const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const result = itemsDb.reopenItem(req.params.id);
if (!result.changes) return res.status(404).json({ error: 'Item not found' });
res.json({ success: true });
}

// -- POST /items/:id/close
function handleCloseItem(req, res) {
const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const result = itemsDb.closeItem(req.params.id);
if (!result.changes) return res.status(404).json({ error: 'Item not found' });
res.json({ success: true });
Expand All @@ -692,6 +723,9 @@ function handleRespondToItem(req, res) {

const item = itemsDb.getItem(req.params.id);
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}

itemsDb.respondToItem(req.params.id, response);
res.json({ success: true });
Expand Down