Skip to content

Fix dispatch log data leak for deleted items (#248) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boot-coco wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix dispatch log data leak for deleted items (#248) #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,9 +1106,10 @@ app.get('/api/v2/adapters', (req, res) => {

// -- GET /api/v2/distributions/:item_id — get dispatch log for an item
app.get('/api/v2/distributions/:item_id', apiReadLimiter, v2Auth, (req, res) => {
// Verify item belongs to caller's app
// Verify item exists and belongs to caller's app
const item = itemsDb.getItem(req.params.item_id);
if (item && req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const log = itemsDb.getDispatchLog(req.params.item_id);
Expand All @@ -1123,9 +1124,10 @@ app.get('/api/v2/distributions/:item_id', apiReadLimiter, v2Auth, (req, res) =>

// -- POST /api/v2/distributions/:item_id/retry — retry failed dispatches for an item
app.post('/api/v2/distributions/:item_id/retry', apiWriteLimiter, v2Auth, async (req, res) => {
// Verify item belongs to caller's app
// Verify item exists and belongs to caller's app
const item = itemsDb.getItem(req.params.item_id);
if (item && req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
if (!item) return res.status(404).json({ error: 'Item not found' });
if (req.v2Auth?.app_id && item.app_id !== req.v2Auth.app_id) {
return res.status(403).json({ error: 'Access denied — item belongs to a different app' });
}
const log = itemsDb.getDispatchLog(req.params.item_id);
Expand Down