Skip to content

Fix dashboard XSS, credential exposure, auth race, and URL crash (#252) #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boot-coco wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix dashboard XSS, credential exposure, auth race, and URL crash (#252) #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions dashboard/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function init() {
if (!isLoggedIn()) {
const extAuth = await getAuthFromExtension();
if (extAuth) {
setAuth(extAuth.authToken, extAuth.authUser);
setAuth(extAuth.token, extAuth.user);
}
}

Expand Down Expand Up @@ -248,7 +248,7 @@ function renderTopPages(topUrls) {
<div class="activity-title">${escHtml(page.source_title || page.source_url)}</div>
<div class="activity-meta">${Number(page.count) || 0} annotation${Number(page.count) !== 1 ? 's' : ''}</div>
</div>`;
if (page.source_url) {
if (page.source_url && /^https?:\/\//i.test(page.source_url)) {
el.addEventListener('click', () => window.open(page.source_url, '_blank'));
}
listEl.appendChild(el);
Expand Down Expand Up @@ -277,7 +277,15 @@ async function loadItemsList(typeFilter) {
for (const item of items.slice(0, 50)) {
const icon = item.type === 'issue' ? '\ud83d\udc1b' : '\ud83d\udcac';
const time = item.created_at ? new Date(item.created_at).toLocaleString() : '';
const sourceLabel = item.source_title || (item.source_url ? new URL(item.source_url).hostname + new URL(item.source_url).pathname.substring(0, 30) : '');
let sourceLabel = item.source_title || '';
if (!sourceLabel && item.source_url) {
try {
const parsed = new URL(item.source_url);
sourceLabel = parsed.hostname + parsed.pathname.substring(0, 30);
} catch {
sourceLabel = item.source_url.substring(0, 40);
}
}
const el = document.createElement('div');
el.className = 'activity-item' + (item.source_url ? ' activity-item-link' : '');
el.innerHTML = `
Expand All @@ -288,7 +296,7 @@ async function loadItemsList(typeFilter) {
${renderItemDispatches(item.dispatches)}
<div class="activity-meta">${time ? escHtml(time) : ''}</div>
</div>`;
if (item.source_url) {
if (item.source_url && /^https?:\/\//i.test(item.source_url)) {
el.addEventListener('click', (e) => {
if (e.target.closest('.dispatch-ext-link')) return;
window.open(item.source_url, '_blank');
Expand Down Expand Up @@ -881,7 +889,10 @@ function renderAuthsTable() {

for (const auth of allAuths) {
const creds = typeof auth.credentials === 'string' ? JSON.parse(auth.credentials) : (auth.credentials || {});
const credSummary = Object.entries(creds).map(([k, v]) => `${k}: ${v}`).join(', ');
const credSummary = Object.entries(creds).map(([k, v]) => {
const masked = typeof v === 'string' && v.length > 4 ? '••••' + v.slice(-4) : '••••';
return `${k}: ${masked}`;
}).join(', ');
const tr = document.createElement('tr');
tr.innerHTML = `
<td>${escHtml(auth.name)}</td>
Expand Down