Fix a potential crash after destroying a node with Spine Skeleton Component in schedule update on native platforms.#18567
Merged
dumganhar merged 5 commits intococos:v3.8.7from Apr 9, 2025
Conversation
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
finscn
reviewed
Apr 7, 2025
| if (!_skeleton) return; | ||
| auto *entity = _entity; | ||
| // entity's node may be set to nullptr while component is destroyed. | ||
| if (!entity || !entity->getNode()) return; |
Contributor
There was a problem hiding this comment.
276行改为
if (!_entity || !_entity->getNode()) return;
并且放到 274行上面更合适吧? 和 SkeletonCacheAnimation.cpp 里的逻辑保持一致
Contributor
Author
There was a problem hiding this comment.
效果是一样的，此处多一个赋值不会产生什么开销
Contributor
There was a problem hiding this comment.
效果是一样的，此处多一个赋值不会产生什么开销
我知道不会产生什么开销. 我只是觉得代码的思路应该一致, 这样代码更优雅一些.
dumganhar
reviewed
Apr 8, 2025
dumganhar
approved these changes
Apr 9, 2025
dumganhar
changed the title
dumganhar
changed the title
AILHC
added a commit
to AILHC/cocos-engine
that referenced
this pull request
May 19, 2025
…ponent in schedule update on native platforms. (cocos#18567)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
#18555
#18561
https://forum.cocos.org/t/topic/165212/629
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: