ohos code optimization #20865
Merged
ohos code optimization #20865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 冰冰冰 <[email protected]>
Signed-off-by: 冰冰冰 <[email protected]>
dumganhar
reviewed
Apr 11, 2025
tests/cpp-tests/CMakeLists.txt
Outdated
| Classes/ExtensionsTest/NetworkTest/SocketIOTest.cpp | ||
| Classes/ExtensionsTest/NetworkTest/WebSocketTest.cpp | ||
| # Classes/ExtensionsTest/NetworkTest/SocketIOTest.cpp | ||
| # Classes/ExtensionsTest/NetworkTest/WebSocketTest.cpp |
There was a problem hiding this comment.
Why comments them ? Would that affect other platforms?
There was a problem hiding this comment.
There was a problem hiding this comment.
But the original code doesn't comment SocketIOTest.cpp and WebSocketTest.cpp.
See https://github.com/cocos2d/cocos2d-x/blob/cocos2d-x-3.5/tests/cpp-tests/CMakeLists.txt#L230
Signed-off-by: 冰冰冰 <[email protected]>
dumganhar
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.5 ohos code optimization