Feat: adds amiyah jones' custom class / exception / objects , lesson 16 #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed my work the 1st time by merging
feat: adds action to testAddStudent()
feat: adds testAddStudent more simple.
feat: adds import to JobReadinessProgram class
feat: adds ta names , and an illlegal exception for invalid ta
… statement fix: changed order of logic in addStudent()
if claassroom is full , assign TA test , display TA. minor details changed as well (parameter , TA)
moved isSuccessful at the bottom
There was a problem hiding this comment.
I would recommend avoiding null values in the constructor for tests. They can be ambiguous to readers and might lead to NullPointerExceptions. Normally, your code should handle edge cases like null, and those scenarios can be tested separately. That said, it's not critical to change the null values here, it's just a suggestion for clarity and to avoid potential issues in the future.
.../objects_app/src/main/java/com/codedifferently/lesson16/amiyahjones/JobReadinessProgram.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 5, 2024 16:46
chore: changed null values in the constructor
in JobReadinessProgram
VicenteVigueras
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.