Skip to content

Feat: Adds Shawn Dunsmore Jr lesson 16 SlotMachine.java and SlotMachi… #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 13, 2024
Merged

Feat: Adds Shawn Dunsmore Jr lesson 16 SlotMachine.java and SlotMachi… #529

merged 16 commits into from
Nov 13, 2024

Conversation

Djtheman1
Copy link
Contributor

…neTest.java

VicenteVigueras
VicenteVigueras suggested changes Nov 13, 2024
View reviewed changes
Copy link

@VicenteVigueras VicenteVigueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Overall!

Please take care of requested changes. Additionally, I'll need you to change package declarations and directories to all lowercase.

@Djtheman1 Djtheman1 closed this Nov 13, 2024
@Djtheman1 Djtheman1 reopened this Nov 13, 2024
VicenteVigueras
VicenteVigueras approved these changes Nov 13, 2024
View reviewed changes
Copy link

@VicenteVigueras VicenteVigueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Shawn!

  • Name your tests based on the method you're testing, Ex. Instead of testMoney_Exists(), I'd probably name it getMoneyNeeded_works()
  • Use actual parameters for unit tests instead of null values.

@VicenteVigueras VicenteVigueras merged commit 448b52e into code-differently:main Nov 13, 2024
1 check passed
@Djtheman1 Djtheman1 deleted the Shawn-lesson16 branch November 13, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@VicenteVigueras VicenteVigueras VicenteVigueras approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Djtheman1 @VicenteVigueras