chore: example components that have been modified with typography-to-mui codemod script #68300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mui codemod script
drizco
commented
Sep 12, 2025
| @@ -394,7 +388,7 @@ export const WorkshopEnrollments: FC = () => { | |||
| title={`Remove Enrollment${s}?`} | |||
| customContent={ | |||
| <Box id="dsco-dialog-description"> | |||
| <Typography semanticTag="div" visualAppearance="body-two"> | |||
| <Typography component="div" variant="body2" gutterBottom> | |||
There was a problem hiding this comment.
example of a wrapper Typography component
drizco
commented
Sep 12, 2025
| > | ||
| <StrongText>{title}</StrongText> | ||
| </Heading2> | ||
| {/* TODO_visualAppearance_dynamic: "size === 's' ? 'body-two' : 'body-one'" */} |
There was a problem hiding this comment.
example of the script adding a TODO comment when the visualAppearance prop is an expression rather than a string. the dev running the script should see this in the diff and fix before merging
drizco
commented
Sep 12, 2025
| @@ -23,26 +19,34 @@ const OrganizerInformation: React.FC<OrganizerInformationProps> = ({ | |||
| }) => { | |||
| return ( | |||
| <div className={moduleStyles.card}> | |||
| <Heading3 visualAppearance="heading-xs">Organizer information</Heading3> | |||
| <Typography component="h3" variant="h6" gutterBottom> | |||
There was a problem hiding this comment.
example of gutterBottom prop being added when noMargin is not on the original component
drizco
commented
Sep 12, 2025
| @@ -283,9 +278,9 @@ export const WorkshopEnrollments: FC = () => { | |||
| orientation="vertical" | |||
| className={styles.actionDivider} | |||
| /> | |||
| <OverlineTwoText noMargin className={styles.numSelectedText}> | |||
| <Typography className={styles.numSelectedText} variant="overline2"> | |||
There was a problem hiding this comment.
example of noMargin prop being removed, since no margin is the default in mui Typography
|
closing as this was just a sample of what the typography-to-mui codemod script would do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: