Skip to content

feat(models): add generic artifact generation to enable caching #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

AndriiSiuta
Copy link
Collaborator

Closes #1021

@AndriiSiuta AndriiSiuta requested a review from BioPhoton July 7, 2025 09:23
@AndriiSiuta AndriiSiuta requested a review from matejchalk as a code owner July 7, 2025 09:23
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 models 🧩 coverage-plugin labels Jul 7, 2025
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found couple of improvements and many unrelated changes. Please review your PRs changes with focus.

@AndriiSiuta AndriiSiuta changed the title Add generic artifact generation to enable caching to model feat(model): add generic artifact generation to enable caching Jul 7, 2025
@AndriiSiuta AndriiSiuta changed the title feat(model): add generic artifact generation to enable caching feat(models): add generic artifact generation to enable caching Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit d7c8dee with previous commit 562c83b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 46 🟡 53 ↑ +7.2
Updates 🟡 77 🟡 74 ↓ −3.2
Documentation 🔴 23 🔴 23 ↑ +0.1
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🟡 61 🟡 61
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 3 groups improved, 👎 1 group regressed, 👍 7 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 46 🟡 53 ↑ +7.2
JS Packages NPM outdated dependencies 🟡 77 🟡 74 ↓ −3.2
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 6.5 s 🟨 5.6 s ↓ −12.5 %
Lighthouse Largest Contentful Paint 🟨 4.0 s 🟨 3.6 s ↓ −9.9 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟨 2.9 s ↓ −9.6 %
Lighthouse Total Blocking Time 🟥 3,840 ms 🟥 1,910 ms ↓ −50.4 %
JS Packages Outdated NPM prod dependencies. 🟨 17 outdated package versions (5 major, 8 minor, 4 patch) 🟨 17 outdated package versions (6 major, 7 minor, 4 patch)  +0 %
Lighthouse Time to Interactive 🟥 12.7 s 🟥 13.0 s ↑ +2.5 %
JSDoc coverage Variables coverage 🟥 218 undocumented variables 🟥 217 undocumented variables ↓ −0.5 %
JSDoc coverage Types coverage 🟥 223 undocumented types 🟥 226 undocumented types ↑ +1.3 %
JSDoc coverage Functions coverage 🟥 476 undocumented functions 🟥 479 undocumented functions ↑ +0.6 %
Code coverage Function coverage 🟩 93.1 % 🟩 93.1 % ↑ +0.1 %
Code coverage Branch coverage 🟨 85.7 % 🟨 85.7 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,900 KiB 🟩 Total size was 2,021 KiB ↑ +6.3 %
Lighthouse Minimizes main-thread work 🟥 16.4 s 🟥 12.6 s ↓ −23.4 %
Lighthouse JavaScript execution time 🟥 6.5 s 🟥 5.7 s ↓ −12 %
Lighthouse Server Backend Latencies 🟩 160 ms 🟩 880 ms ↑ +450.7 %
Lighthouse Max Potential First Input Delay 🟥 2,140 ms 🟥 1,670 ms ↓ −21.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 68 KiB 🟥 Potential savings of 69 KiB ↑ +170.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 450 ms 🟩 Root document took 490 ms ↑ +7.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,248 elements 🟥 2,259 elements ↑ +0.5 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 20 ms ↑ +39.6 %
Code coverage Line coverage 🟨 86.5 % 🟨 86.6 % ↑ +0.1 %

582 other audits are unchanged.

vmasek
vmasek previously approved these changes Jul 7, 2025
BioPhoton
BioPhoton previously approved these changes Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 models 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generic artifact generation to enable caching to model
4 participants