Skip to content

Conversation

BioPhoton
Copy link
Collaborator

This PR:

  • removes the generator to add a target to a project. from V19 on this is done over plugins

Copy link

nx-cloud bot commented Sep 6, 2025

View your CI Pipeline Execution ↗ for commit 7b131b3

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 1m 3s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m 28s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 4m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-06 23:57:13 UTC

Copy link

pkg-pr-new bot commented Sep 6, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1110

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1110

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1110

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1110

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1110

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1110

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1110

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1110

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1110

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1110

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1110

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1110

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1110

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1110

commit: 7b131b3

@BioPhoton BioPhoton changed the title refactor: remove target generator in favore of task inference refactor: remove target generator in favour of task inference Sep 6, 2025
Copy link

github-actions bot commented Sep 6, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit e41c6fa with previous commit c7d314e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 37 🔴 35 ↓ −1.9
Code coverage 🟡 90 🟡 90 ↓ −0.1
Documentation 🔴 24 🔴 24 ↑ +0.1
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 1 audit improved, 👎 6 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 37 🔴 35 ↓ −1.9
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 24 🔴 24 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 5.8 s 🟥 6.5 s ↑ +11.4 %
Lighthouse Total Blocking Time 🟥 2,000 ms 🟥 2,480 ms ↑ +23.6 %
Lighthouse Time to Interactive 🟥 16.1 s 🟥 17.1 s ↑ +6 %
Code coverage Line coverage 🟨 86.3 % 🟨 86.2 % ↓ −0.1 %
JSDoc coverage Functions coverage 🟥 521 undocumented functions 🟥 520 undocumented functions ↓ −0.2 %
Code coverage Branch coverage 🟨 85.5 % 🟨 85.5 % ↓ −0.1 %
Code coverage Function coverage 🟩 92.3 % 🟩 92.3 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,683 KiB 🟨 Total size was 2,726 KiB ↑ +1.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.4 %
Lighthouse Minimizes main-thread work 🟥 9.4 s 🟥 11.6 s ↑ +23 %
Lighthouse JavaScript execution time 🟥 4.1 s 🟥 5.1 s ↑ +24.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +6 %
Lighthouse Largest Contentful Paint 🟥 11.1 s 🟥 10.8 s ↓ −2.4 %
Lighthouse Server Backend Latencies 🟩 980 ms 🟩 1,160 ms ↑ +18.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 96 KiB 🟥 Potential savings of 81 KiB ↓ −33.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −23.3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 604 KiB 🟥 Potential savings of 590 KiB ↓ −15.6 %
Lighthouse Initial server response time was short 🟩 Root document took 420 ms 🟩 Root document took 550 ms ↑ +29.7 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 70 ms ↑ +269 %
Lighthouse Max Potential First Input Delay 🟥 760 ms 🟥 810 ms ↑ +6.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,296 elements 🟥 2,288 elements ↓ −0.3 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.0 s ↓ −0.1 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↑ +∞ %

587 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review September 7, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant