Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-coverage): introduce coverage plugin #457

Merged
merged 12 commits into from
Feb 5, 2024
Merged

feat(plugin-coverage): introduce coverage plugin #457

merged 12 commits into from
Feb 5, 2024

Conversation

Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Feb 1, 2024 •
edited
Loading

Related to #430

This PR is the MVP version of coverage plugin. It includes:

  • a use case where one already has the results and wants to include them in the report/dashboard
  • LCOV coverage format only
  • line, branch and function coverage
  • documentation of the plugin and link in CLI documentation
  • updated dependencies for E2E tests

The plugin can be included in a code-pushup.config.

Next steps to finish this plugin are listed in #430 criteria.

Screenshots

Dashboard

image

Category detail

image

Issues

image

@Tlacenka Tlacenka self-assigned this Feb 1, 2024
BioPhoton
BioPhoton reviewed Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.
Plus you could link it in the main readme.

@Tlacenka
Copy link
Collaborator Author

Tlacenka commented Feb 2, 2024

Plus you could link it in the main readme.

@BioPhoton
I thought the main README only includes example plugins or preset plugins which are already published. I plan to finalise the plugin in a follow-up PR and deal with the publishing and README there. But maybe I'm missing something or with the package release after merge this would already get published automatically? In which case I can add it there.

matejchalk
matejchalk reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 It looks really promising, excited to have another plugin shipped soon 🎉

@Tlacenka Tlacenka force-pushed the coverage-plugin branch 2 times, most recently from 9e4ea82 to 457e578 Compare February 2, 2024 13:36
@Tlacenka Tlacenka force-pushed the coverage-plugin branch 4 times, most recently from 81f200d to 1f8d4db Compare February 2, 2024 18:04
@Tlacenka Tlacenka marked this pull request as ready for review February 2, 2024 18:04
matejchalk
matejchalk previously approved these changes Feb 2, 2024
View reviewed changes
BioPhoton
BioPhoton previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to merge this one!

@Tlacenka Tlacenka dismissed stale reviews from BioPhoton and matejchalk via accf824 February 5, 2024 09:00
@Tlacenka Tlacenka requested a review from matejchalk February 5, 2024 09:03
@Tlacenka Tlacenka merged commit 3195da2 into main Feb 5, 2024
@Tlacenka Tlacenka deleted the coverage-plugin branch February 5, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton BioPhoton left review comments

Assignees

@Tlacenka Tlacenka

Labels
🦾 CI/CD Continuous integration and deployment 🧩 cli 🧩 core 🧩 coverage-plugin 🧩 eslint-plugin 🧩 lighthouse-plugin 🧩 models 🔬 testing writing tests 🧩 utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tlacenka @BioPhoton @matejchalk