Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-coverage): add tool command, nx helper #495

Merged
merged 7 commits into from
Feb 13, 2024
Merged

feat(plugin-coverage): add tool command, nx helper #495

merged 7 commits into from
Feb 13, 2024

Conversation

Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Feb 12, 2024 •
edited
Loading

Related to #430

In this PR, I address the following acceptance criteria:

  • As I transformed the plugin to use only RunnerConfig, one can now optionally add a tool to be run to gather the results.
  • I created an nx helper function to help parse coverage paths to feed to the plugin.
  • I added the plugin as a dependency for all our main cli commands.
  • I included basic error handling and updated the documentation.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🦾 CI/CD Continuous integration and deployment 🧩 utils 🧩 coverage-plugin 🛠️ tooling labels Feb 12, 2024
@Tlacenka Tlacenka force-pushed the coverage-plugin-vol2 branch from 324aaec to 0c2423d Compare February 12, 2024 17:50
@Tlacenka Tlacenka force-pushed the coverage-plugin-vol2 branch from 0c2423d to b7e64b4 Compare February 12, 2024 18:17
@Tlacenka Tlacenka force-pushed the coverage-plugin-vol2 branch from b7e64b4 to 0ff2223 Compare February 12, 2024 19:43
@Tlacenka Tlacenka marked this pull request as ready for review February 12, 2024 19:48
@Tlacenka Tlacenka requested a review from matejchalk February 12, 2024 19:48
matejchalk
matejchalk reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvements, will simplify adoption in Nx a lot 🙂

@Tlacenka Tlacenka requested a review from matejchalk February 13, 2024 12:08
matejchalk
matejchalk previously approved these changes Feb 13, 2024
View reviewed changes
@Tlacenka Tlacenka requested a review from matejchalk February 13, 2024 13:56
@Tlacenka Tlacenka merged commit a6f645a into main Feb 13, 2024
18 checks passed
@Tlacenka Tlacenka deleted the coverage-plugin-vol2 branch February 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@Tlacenka Tlacenka

Labels
🦾 CI/CD Continuous integration and deployment 🧩 coverage-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlacenka @matejchalk