Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-coverage): allow passing results as strings #499

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Feb 14, 2024

Related to #430
In this PR, I allow passing result paths as strings.
However, this approach can be only used for a single project setup atm as LCOV needs to prepend path to root in its records with relative paths.

Once another format is supported, the full potential along with globs will be unlocked. Created #498 for this.

@Tlacenka Tlacenka requested a review from matejchalk February 14, 2024 11:01
@Tlacenka Tlacenka self-assigned this Feb 14, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 coverage-plugin labels Feb 14, 2024
matejchalk
matejchalk previously approved these changes Feb 14, 2024
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@Tlacenka Tlacenka force-pushed the coverage-paths-improvement branch from 2f2b5bd to f0b5460 Compare February 14, 2024 11:25
@Tlacenka Tlacenka merged commit 6813021 into main Feb 14, 2024
@Tlacenka Tlacenka deleted the coverage-paths-improvement branch February 14, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 coverage-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants