-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(plugin-eslint): lint nx projects in separate processes #651
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e365bab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 41a95b0 with source commit b2a180e. 🏷️ Categories🗃️ Groups👍 3 groups improved
18 other groups are unchanged. 🛡️ Audits👍 10 audits improved, 👎 1 audit regressed, 8 audits changed without impacting score
504 other audits are unchanged. |
b094fca
to
e365bab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this improvement a lot!
I looked both at the plugin code and the tests.
While there are some generic tests and bigger snapshots of higher complexity, their refactor does not belong to this PR.
Closes #629
Tested by executing plugin from
dist
on code-pushup/portal. Previously, this would crash withoutNODE_OPTIONS=--max-old-space-size=8192
. Now it successfully completes without any memory increase.Also created follow-up issue for further optimization: