Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-typescript): add TS core logic #932

Merged
merged 13 commits into from
Feb 14, 2025
Merged

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 12, 2025

part of #902

Copy link

github-actions bot commented Feb 12, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 8aa298b with source commit fc53905.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 50 ↓ −4
Documentation 🔴 23 🔴 23 ↑ +0.2
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 79 🟡 79
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 4 audits improved, 👎 5 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 50 ↓ −4
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.2
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 3.7 s ↑ +13.7 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 3.0 s ↑ +8.3 %
JSDoc coverage Functions coverage 🟥 439 undocumented functions 🟥 447 undocumented functions ↑ +1.8 %
Lighthouse Time to Interactive 🟥 13.5 s 🟥 13.1 s ↓ −3.6 %
JSDoc coverage Variables coverage 🟥 195 undocumented variables 🟥 200 undocumented variables ↑ +2.6 %
JSDoc coverage Types coverage 🟥 201 undocumented types 🟥 209 undocumented types ↑ +4 %
Code coverage Line coverage 🟨 89.7 % 🟨 89.8 % ↑ +0.1 %
Code coverage Function coverage 🟩 93 % 🟩 92.9 % ↓ −0.1 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,817 KiB ↓ −0.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −3.6 %
Lighthouse JavaScript execution time 🟥 6.9 s 🟥 6.5 s ↓ −6 %
Lighthouse Minimizes main-thread work 🟥 14.0 s 🟥 14.4 s ↑ +2.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Total Blocking Time 🟥 3,750 ms 🟥 3,520 ms ↓ −6.2 %
Lighthouse Max Potential First Input Delay 🟥 1,500 ms 🟥 1,690 ms ↑ +12.5 %
Lighthouse Initial server response time was short 🟩 Root document took 520 ms 🟩 Root document took 370 ms ↓ −29.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 920 ms 🟥 Potential savings of 1,030 ms ↑ +12.4 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 170 ms ↑ +76.8 %
Lighthouse Speed Index 🟨 5.6 s 🟨 5.6 s ↑ +0.8 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 40 ms ↑ +124.8 %
Lighthouse Avoid large layout shifts 🟩 1 layout shift found 🟩 0 ↓ −100 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

573 other audits are unchanged.

@BioPhoton BioPhoton merged commit afd50e7 into main Feb 14, 2025
16 checks passed
@BioPhoton BioPhoton deleted the add-ts-core-logic branch February 14, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants