Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-typescript): add plugin logic #936

Merged
merged 13 commits into from
Feb 17, 2025
Merged

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 14, 2025

part of #902

Copy link

github-actions bot commented Feb 14, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 18f321d with source commit afd50e7.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 48 ↓ −6.6
Documentation 🔴 23 🔴 23 ↑ +0.1
Code coverage 🟢 91 🟢 91 ↑ +0.1
Security 🟡 79 🟡 79
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 3 audits improved, 👎 7 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 48 ↓ −6.6
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 4.5 s 🟥 6.9 s ↑ +52.2 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 2.9 s ↑ +8.5 %
Lighthouse Time to Interactive 🟥 12.4 s 🟥 14.5 s ↑ +17.5 %
Lighthouse Total Blocking Time 🟥 2,360 ms 🟥 6,410 ms ↑ +172 %
Lighthouse Largest Contentful Paint 🟨 3.7 s 🟨 3.8 s ↑ +1.8 %
JSDoc coverage Functions coverage 🟥 447 undocumented functions 🟥 448 undocumented functions ↑ +0.2 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.9 % ↑ +0.1 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↓ −0.1 %
JSDoc coverage Variables coverage 🟥 200 undocumented variables 🟥 203 undocumented variables ↑ +1.5 %
Code coverage Function coverage 🟩 92.9 % 🟩 92.9 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 10.7 s 🟥 19.9 s ↑ +87 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +17.5 %
Lighthouse JavaScript execution time 🟥 5.5 s 🟥 7.5 s ↑ +35.5 %
Lighthouse Max Potential First Input Delay 🟥 1,530 ms 🟥 2,250 ms ↑ +47.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,818 KiB 🟩 Total size was 1,818 KiB ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,000 ms 🟥 Potential savings of 1,040 ms ↑ +4 %
Lighthouse Initial server response time was short 🟩 Root document took 330 ms 🟩 Root document took 360 ms ↑ +11.8 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 110 ms ↑ +25.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↓ −2.2 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↑ +36.2 %
Lighthouse Avoid large layout shifts 🟩 1 layout shift found 🟩 0 ↓ −100 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

573 other audits are unchanged.

@BioPhoton BioPhoton requested a review from matejchalk February 15, 2025 12:58
@BioPhoton BioPhoton merged commit df5bfa1 into main Feb 17, 2025
16 checks passed
@BioPhoton BioPhoton deleted the add-ts-plugin-logic branch February 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants