fix(runtime-fallback): skip equivalent claude aliases#3322
fix(runtime-fallback): skip equivalent claude aliases#3322RaviTharuma wants to merge 3 commits intocode-yeongyu:devfrom
Conversation
Prevent runtime fallback from cycling through provider aliases that resolve to the same underlying Claude family model. This keeps retry handling moving toward a genuinely distinct fallback model instead of appearing to fallback while staying on the same effective model. Constraint: Live retry/fallback bug is in /Users/ravi/Code/personal/oh-my-opencode, while oh-my-openagent contribution work remains isolated to /Users/ravi/Code/forks/oh-my-openagent Rejected: Change fallback chain precedence (category vs agent) first | lower-confidence root cause than equivalent-model retry Confidence: high Scope-risk: narrow Directive: Keep alias-equivalence logic limited to model families that are intentionally interchangeable for runtime failover, and expand with targeted tests before broadening provider-family collapsing Tested: bun run typecheck Tested: bun test src/hooks/runtime-fallback/index.test.ts src/hooks/runtime-fallback/error-classifier.test.ts src/plugin/event.model-fallback.test.ts Not-tested: Full live end-to-end session repro against external provider outages
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cac1d01947
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: The logic skips equivalent models across different providers (e.g., Bedrock vs Anthropic). This is a regression if a user relies on provider redundancy for the same model during outages.
Limit runtime-fallback equivalence collapsing to Claude-family aliases only so explicit non-Claude suffixes like -high remain meaningful fallback targets. Constraint: Preserve the live Claude alias skip fix while addressing Codex review feedback on PR code-yeongyu#3322 Rejected: Keep global -high/-max/-thinking stripping | would collapse distinct non-Claude fallback targets Confidence: high Scope-risk: narrow Directive: Only broaden equivalence collapsing when a provider/model family has explicit tests proving the variants are interchangeable for runtime failover Tested: bun run typecheck Tested: bun test src/hooks/runtime-fallback/index.test.ts src/hooks/runtime-fallback/error-classifier.test.ts src/plugin/event.model-fallback.test.ts Not-tested: Full live outage repro across non-Claude provider suffix variants
|
Re: #3322 (comment) Good catch — this was valid. I pushed a follow-up fix in That preserves the intended runtime-fallback alias skip for equivalent Claude provider aliases, while keeping explicit non-Claude suffixes like Re-verified after the change with:
So the original Claude alias loop fix remains, but the broader non-Claude regression is no longer present. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edb2d7f2b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Treat parsed variant as part of runtime-fallback model equivalence so variant-only fallback hops remain distinct while preserving the existing Claude-family alias handling. Constraint: Oracle verification flagged unresolved PR code-yeongyu#3322 review concerns about variant equivalence and remote state Rejected: Preserve provider identity in equivalence | contradicted the original live-loop fix for equivalent Claude aliases Confidence: medium Scope-risk: narrow Directive: Any future equivalence broadening must prove both live retry-loop behavior and variant/provider semantics with targeted tests before merging Tested: bun run typecheck Tested: bun test src/hooks/runtime-fallback/index.test.ts src/hooks/runtime-fallback/error-classifier.test.ts src/plugin/event.model-fallback.test.ts Not-tested: Full live end-to-end repro across all provider redundancy policies
|
Re: #3322 (comment) and #3322 (comment) I tightened this one further in Final behavior now is:
Re-verified after the latest change with:
So the current PR state now addresses:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 669afe22d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Re: #3322 (comment) and #3322 (comment) I rechecked the current branch state against the intended runtime behavior. The final implementation on the PR branch keeps:
That means the two latest concerns are now addressed in the current branch state:
I also re-ran:
with the current local branch state before re-requesting review. |
1 participant
Summary
Verification
Summary by cubic
Skip equivalent Claude-family provider aliases during runtime fallback so retries move to a truly different model, not another alias. Variants are treated as distinct, and non-Claude suffixes like -high/-max/-thinking remain meaningful.
-thinking,-max,-highonly for Claude models.openai/gpt-5.4, and preserved-agent retry behavior.Written for commit 669afe2. Summary will update on new commits.