fix(agent-display): remove zero-width sort prefixes from runtime names

[LeekJay]

Summary

• Removes AGENT_LIST_SORT_PREFIXES entirely to prevent string corruption (like missing 'U' in 'Ultraworker') when OpenCode renders labels in its TUI.
• Updates getAgentRuntimeName to return identical clean strings as getAgentDisplayName.
• Implements a defense-in-depth layer in the CLI terminal output renderer (stripInvisibleAgentCharacters) to ensure no residual invisible characters are printed.

Changes

• Modified src/shared/agent-display-names.ts to remove the ZWSP-based prefix injection, relying strictly on the existing order property injection via CANONICAL_CORE_AGENT_ORDER for agent list sorting.
• Modified src/cli/run/output-renderer.ts to aggressively clean the agent string before printing it with picocolors.
• Added new regression test src/cli/run/output-renderer.test.ts.
• Updated test snapshots in src/shared/agent-display-names.test.ts, src/plugin-handlers/agent-key-remapper.test.ts and src/plugin-handlers/command-config-handler.test.ts to assert that zero-width space characters are no longer present.

Testing

bun run typecheck
bun test

---

Summary by cubic

Removed zero-width sort prefixes from agent names to fix truncated TUI labels. Runtime and list display names are now clean and consistent, and the CLI strips invisible characters before printing.

• Bug Fixes
  • Removed ZWSP prefixes; getAgentRuntimeName and getAgentListDisplayName now match getAgentDisplayName.
  • Sorting relies only on CANONICAL_CORE_AGENT_ORDER.
  • CLI sanitizes labels via stripInvisibleAgentCharacters and falls back to color profiles by clean name before styling with picocolors; added a renderAgentHeader test and updated related tests to assert no zero-width chars.

^{Written for commit f5927e4. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 6 files

Confidence score: 5/5

• This PR looks low risk to merge because the only reported issue is a low-severity documentation/comment mismatch (2/10) rather than a behavioral or runtime defect.
• The note in src/shared/agent-display-names.ts should be updated so the comment matches current behavior (no runtime sort prefixes from getAgentRuntimeName()), which helps prevent future confusion during maintenance.
• Pay close attention to src/shared/agent-display-names.ts - align the outdated comment with the new no-prefix behavior.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/shared/agent-display-names.ts">

<violation number="1" location="src/shared/agent-display-names.ts:63">
P3: Update this comment to match the new no-prefix behavior; it still says `getAgentRuntimeName()` adds runtime sort prefixes.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P3: Update this comment to match the new no-prefix behavior; it still says getAgentRuntimeName() adds runtime sort prefixes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/shared/agent-display-names.ts, line 63:

<comment>Update this comment to match the new no-prefix behavior; it still says `getAgentRuntimeName()` adds runtime sort prefixes.</comment>

<file context>
@@ -56,25 +46,25 @@ export function getAgentRuntimeName(configKey: string): string {
- * Runtime-facing agent name used for OpenCode list ordering.
+ * List-facing agent display name.
+ *
+ * This must stay human-readable. Runtime sort prefixes belong only in the
+ * agent `name` field via getAgentRuntimeName().
  */
</file context>

Suggested change

	* This must stay human-readable. Runtime sort prefixes belong only in the
	* agent `name` field via getAgentRuntimeName().
	* This must stay human-readable.
	* Runtime and list display names are intentionally identical here.

[cubic-dev-ai]

0 issues found across 2 files (changes from recent commits).

_{Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.}