fix(agents): replace deprecated getAgentListDisplayName with getAgentDisplayName (fixes #3281) by MoerAI · Pull Request #3407 · code-yeongyu/oh-my-openagent

MoerAI · 2026-04-14T01:34:38Z

Summary

Remove ZWSP-based agent sort prefixes from config handler outputs to fix agent name resolution failures

Problem

getAgentListDisplayName() prepends zero-width space (ZWSP) characters to agent display names for TUI list ordering. These invisible characters leak into HTTP headers, config keys, and agent lookup paths, causing:

Agent name resolution failures (e.g., /compact command cannot find default agent)
Display corruption on terminals that don't render ZWSP correctly
Inconsistent agent name matching across the codebase

Fix

Replaced all getAgentListDisplayName() calls in config/tool/command handlers with getAgentDisplayName(), which returns clean display names without ZWSP prefixes. The agent-key-remapper.ts now uses getAgentDisplayName for both object keys and the name field. Updated all corresponding test expectations.

Changes

File	Change
`src/plugin-handlers/agent-key-remapper.ts`	Use `getAgentDisplayName` instead of `getAgentListDisplayName`/`getAgentRuntimeName`
`src/plugin-handlers/agent-config-handler.ts`	Use `getAgentDisplayName` for `default_agent` resolution
`src/plugin-handlers/agent-priority-order.ts`	Use `getAgentDisplayName` for priority ordering keys
`src/plugin-handlers/command-config-handler.ts`	Use `getAgentDisplayName` for command agent refs
`src/plugin-handlers/tool-config-handler.ts`	Use `getAgentDisplayName` for tool permission keys
`src/shared/agent-display-names.test.ts`	Update test expectations
`src/plugin-handlers/*.test.ts`	Update 7 test files to expect clean display names
`src/plugin-interface.test.ts`	Update test expectations
`src/plugin/chat-message.test.ts`	Update test expectations

Fixes #3281
Also addresses #3337, #3307, #3347 (ZWSP display issues)
Also addresses #3245 (/compact command agent resolution failure)

Summary by cubic

Removed zero‑width space (ZWSP) prefixes from agent names and replaced all uses of getAgentListDisplayName with getAgentDisplayName so config, routing, and headers use clean names. Fixes #3281 and also unblocks /compact and resolves TUI ZWSP artifacts (#3337, #3307, #3347, #3245).

Bug Fixes
- Config: agent-config-handler, command-config-handler, tool-config-handler now resolve default_agent, refs, and permission keys via getAgentDisplayName.
- Mapping/ordering: agent-key-remapper and agent-priority-order use clean display names for keys and sorting.
- Cleanups: removed all getAgentListDisplayName imports, restored missing getAgentDisplayName imports, and updated tests to expect clean names.

^{Written for commit ad09192. Summary will update on new commits.}

…DisplayName (fixes code-yeongyu#3281)

…nfig handlers

MoerAI · 2026-04-14T01:35:08Z

I have read the CLA Document and I hereby sign the CLA

cubic-dev-ai

3 issues found across 14 files

Confidence score: 2/5

There is a high-confidence merge risk: src/plugin-handlers/config-handler.test.ts has a duplicate import specifier, which makes the test file invalid TypeScript and is likely to fail checks immediately.
src/plugin-handlers/agent-config-handler.test.ts removes PluginComponents while it is still referenced as a type, creating an unresolved type error that breaks source validity.
src/plugin-handlers/agent-key-remapper.test.ts also appears out of sync with the new display-name sorting behavior, so test expectations should be updated to avoid regression in test outcomes.
Pay close attention to src/plugin-handlers/config-handler.test.ts, src/plugin-handlers/agent-config-handler.test.ts, and src/plugin-handlers/agent-key-remapper.test.ts - compile-time/type validity and test expectation mismatches are likely to block a clean merge.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/plugin-handlers/agent-config-handler.test.ts">

<violation number="1" location="src/plugin-handlers/agent-config-handler.test.ts:14">
P1: Custom agent: **Opencode Compatibility**

Removing the `PluginComponents` import leaves an unresolved type reference in this test file, so the change breaks source validity.</violation>
</file>

<file name="src/plugin-handlers/config-handler.test.ts">

<violation number="1" location="src/plugin-handlers/config-handler.test.ts:7">
P0: Custom agent: **Opencode Compatibility**

Duplicate import specifier makes the test file invalid TypeScript.</violation>
</file>

<file name="src/plugin-handlers/agent-key-remapper.test.ts">

<violation number="1" location="src/plugin-handlers/agent-key-remapper.test.ts:99">
P2: Update the expected sorted order to match the clean display names, or this test will fail after removing the ZWSP prefixes.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/plugin-handlers/config-handler.test.ts

src/plugin-handlers/agent-config-handler.test.ts

cubic-dev-ai · 2026-04-14T01:38:15Z

src/plugin-handlers/agent-key-remapper.test.ts

+      getAgentDisplayName("sisyphus"),
+      getAgentDisplayName("hephaestus"),
+      getAgentDisplayName("prometheus"),
+      getAgentDisplayName("atlas"),


P2: Update the expected sorted order to match the clean display names, or this test will fail after removing the ZWSP prefixes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/plugin-handlers/agent-key-remapper.test.ts, line 99: <comment>Update the expected sorted order to match the clean display names, or this test will fail after removing the ZWSP prefixes.</comment> <file context> @@ -96,10 +96,10 @@ describe("remapAgentKeysToDisplayNames", () => { - getAgentListDisplayName("hephaestus"), - getAgentListDisplayName("prometheus"), - getAgentListDisplayName("atlas"), + getAgentDisplayName("sisyphus"), + getAgentDisplayName("hephaestus"), + getAgentDisplayName("prometheus"), </file context>

Suggested change

getAgentDisplayName("sisyphus"),

getAgentDisplayName("hephaestus"),

getAgentDisplayName("prometheus"),

getAgentDisplayName("atlas"),

getAgentDisplayName("atlas"),

getAgentDisplayName("hephaestus"),

getAgentDisplayName("prometheus"),

getAgentDisplayName("sisyphus"),

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8aaa724932

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-14T01:42:08Z

src/plugin-handlers/agent-config-handler.ts

      (params.config as { default_agent?: string }).default_agent =
-        getAgentListDisplayName(configuredDefaultAgent);
+        getAgentDisplayName(configuredDefaultAgent);


Normalize default_agent through config-key parser

default_agent is now canonicalized with getAgentDisplayName(configuredDefaultAgent), which does not strip legacy ZWSP list prefixes. If an existing config still contains an old prefixed value (for example from prior releases), this assignment keeps the prefix while config.agent keys are remapped to unprefixed display names, so the default agent can stop matching any exported agent key after upgrade. Resolve the input with getAgentConfigKey(...) before converting back to a display name.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-14T01:42:08Z

src/plugin-handlers/tool-config-handler.ts

+  return (agentResult[getAgentDisplayName(key)] ?? agentResult[key]) as
    | AgentWithPermission


Preserve legacy prefixed-key lookup in agentByKey

This helper no longer checks the legacy list-display form, so agent permission patching now misses entries keyed with old prefixed names (for example \u200B...Atlas - Plan Executor). Those legacy keys can still appear in upgraded configs, and when they do, blocks like atlas/sisyphus permission hardening are skipped, leading to inconsistent tool permissions. Keep a prefixed-key fallback or normalize agentResult keys before lookups.

Useful? React with 👍 / 👎.

cubic-dev-ai

0 issues found across 2 files (changes from recent commits).

_{Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad09192318

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-14T09:50:46Z

src/plugin-handlers/agent-key-remapper.ts


  for (const [key, value] of Object.entries(agents)) {
-    const displayName = getAgentListDisplayName(key)
+    const displayName = getAgentDisplayName(key)


Normalize legacy prefixed keys before remapping agents

Using getAgentDisplayName(key) directly leaves legacy ZWSP-prefixed keys unchanged, while builtin config keys (for example atlas) are remapped to the new clean display name. In upgraded configs that still contain prefixed keys, this now produces two entries for the same core agent (clean and prefixed), and downstream logic keyed by clean names can skip the legacy entry (ordering/permission updates), causing inconsistent runtime behavior.

Useful? React with 👍 / 👎.

MoerAI added 3 commits April 10, 2026 13:07

fix(agents): replace deprecated getAgentListDisplayName with getAgent…

7c69a12

…DisplayName (fixes code-yeongyu#3281)

fix: update test expectations to use clean display names without ZWSP

ddfe87a

fix: replace remaining getAgentListDisplayName in command and tool co…

8aaa724

…nfig handlers

cubic-dev-ai bot reviewed Apr 14, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 14, 2026

View reviewed changes

fix: restore missing imports and remove duplicate import specifier

ad09192

cubic-dev-ai bot reviewed Apr 14, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(agents): replace deprecated getAgentListDisplayName with getAgentDisplayName (fixes #3281)#3407

fix(agents): replace deprecated getAgentListDisplayName with getAgentDisplayName (fixes #3281)#3407
MoerAI wants to merge 4 commits intocode-yeongyu:devfrom
MoerAI:fix/agent-header-strip-zwsp

MoerAI commented Apr 14, 2026 •

edited by cubic-dev-ai bot

Loading

Uh oh!

MoerAI commented Apr 14, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot Apr 14, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Apr 14, 2026

Uh oh!

chatgpt-codex-connector bot Apr 14, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		return (agentResult[getAgentDisplayName(key)] ?? agentResult[key]) as
		\| AgentWithPermission

Conversation

MoerAI commented Apr 14, 2026 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Fix

Changes

Summary by cubic

Uh oh!

MoerAI commented Apr 14, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MoerAI commented Apr 14, 2026 •

edited by cubic-dev-ai bot

Loading

cubic-dev-ai bot Apr 14, 2026 •

edited

Loading