Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference update request #14

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix reference update request #14

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3ee9579
Remove old comment about side-band
paulyoung Feb 8, 2023
bcac6d2
Capability list should have a trailing space
paulyoung Feb 8, 2023
7218b48
Command list should end with a line feed
paulyoung Feb 8, 2023
b4ba564
Request both report-status and report-status-v2
paulyoung Feb 8, 2023
d198d66
Update comment about status report
paulyoung Feb 8, 2023
54995ce
Add TODO for object-format and agent cabapilities
paulyoung Feb 8, 2023
3b67645
Use the format described in more comprehensive doc
paulyoung Feb 23, 2023
12fa611
Add FIXME
paulyoung Feb 23, 2023
8dd57ef
Merge branch 'main' into paulyoung/update-request
paulyoung Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/git-remote-helper/src/commands/push.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// https://git-scm.com/docs/pack-protocol#_reference_update_request_and_packfile_transfer

use crate::git::service::receive_pack;
use anyhow::anyhow;
use git::bstr::ByteSlice as _;
Expand Down Expand Up @@ -198,8 +200,12 @@ where
// We parse the status report from the response and write our own
// status report to stdout in the format that remote helpers are
// expected to produce.
//
// FIXME: we only want to include the capability list on the first
// line.
let chunk = format!(
"{} {} {}\0 report-status report-status-v2 \n",
// TODO: object-format=sha1 and agent=
"{} {} {}\0report-status report-status-v2\n",
dst_id.to_hex(),
src_id.to_hex(),
dst
Expand Down