Skip to content

Conversation

@gimlichael
Copy link
Member

@gimlichael gimlichael commented Nov 11, 2025

This pull request updates the GitHub Actions workflow configuration to improve reliability of the build and test jobs. The main change is the addition of the restore: true flag in both the Linux and Windows test job steps, which should help resolve intermittent failures related to xUnitv3 dependencies.

Workflow reliability improvements:

  • .github/workflows/pipelines.yml: Added restore: true to the Linux test job to address random failures potentially caused by xUnitv3 requirements or excessive load on GitHub runners.
  • .github/workflows/pipelines.yml: Added restore: true to the Windows test job for the same reasons, aiming to ensure xUnitv3 dependencies are properly restored before running tests.

Summary by CodeRabbit

  • Documentation

    • Standardized whitespace formatting across package README files.
  • Chores

    • Enabled the Microsoft Testing Platform runner for test projects.
    • Removed package restore pruning for Windows test builds.
    • Bumped three test-related packages from pre-release to stable 11.0.0.

@gimlichael gimlichael self-assigned this Nov 11, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

Whitespace normalization across many package README files (removed extra space before .NET 10), MSBuild updates: removed RestoreEnablePackagePruning from a Windows+test PropertyGroup and added UseMicrosoftTestingPlatformRunner (true) for test projects; bumped three Codebelt.Extensions.* package versions to 11.0.0 in Directory.Packages.props.

Changes

Cohort / File(s) Summary
README Whitespace Normalization
.nuget/Cuemon.*/*/README.md, README.md
Removed an extra space between "and" and .NET 10 across package README files for consistent inline formatting.
MSBuild Test Project Configuration
Directory.Build.props
Removed RestoreEnablePackagePruning from the PropertyGroup conditioned on IsTestProject && IsWindows; added UseMicrosoftTestingPlatformRunner = true in the PropertyGroup conditioned on IsTestProject.
Package version bumps
Directory.Packages.props
Updated package versions: Codebelt.Extensions.Xunit, Codebelt.Extensions.Xunit.Hosting, and Codebelt.Extensions.Xunit.Hosting.AspNetCore from 11.0.0-rc.211.0.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review focus:
    • Directory.Build.props: verify test runner change (UseMicrosoftTestingPlatformRunner) and that removing RestoreEnablePackagePruning has no unintended restore/prune effects on Windows test projects.
    • Directory.Packages.props: confirm package bumps are intended and compatible with CI/test matrix.
    • README changes: cosmetic; spot-check a few files to confirm no other edits slipped in.

Possibly related PRs

  • V9.0.0/cpm #99 — Modifies MSBuild infrastructure (Directory.Build.props/Directory.Packages.props); likely related to test/build config changes.
  • V9.0.0/service pack 1 #91 — Changes to build configuration and test-related settings, overlapping with the test-runner/property updates here.
  • V9.0.0/rtm #102 — Also updates Codebelt.Extensions.* package declarations; related to the version bumps in this PR.

Poem

🐇 I hopped through docs both near and far,
Trimmed tiny spaces like a shining star,
Bumped three packages, set tests to run true,
A tidy repo — fresh as morning dew! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'V10.0.0/hotfix' is a branch/version identifier, not a descriptive summary of the actual changes in the PR (whitespace fixes in READMEs, Directory.Build.props updates, Directory.Packages.props version bumps, and workflow modifications). Replace the branch name with a clear, descriptive title summarizing the main changes, such as 'Update testing infrastructure and package versions for v10.0.0 release' or 'Fix whitespace in READMEs and update xUnit packages to stable 11.0.0'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v10.0.0/hotfix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c63f86 and dec1f63.

📒 Files selected for processing (1)
  • Directory.Packages.props (1 hunks)
🔇 Additional comments (1)
Directory.Packages.props (1)

7-9: Verified: stable versions exist with no security advisories.

All three packages (Codebelt.Extensions.Xunit, Codebelt.Extensions.Xunit.Hosting, and Codebelt.Extensions.Xunit.Hosting.AspNetCore) have version 11.0.0 published on NuGet. The upgrade from 11.0.0-rc.2 to 11.0.0 is valid, and no security vulnerabilities were detected.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.94%. Comparing base (c4ed5ad) to head (dec1f63).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   79.86%   79.94%   +0.08%     
==========================================
  Files         595      595              
  Lines       18317    18289      -28     
  Branches     1870     1868       -2     
==========================================
- Hits        14629    14622       -7     
+ Misses       3618     3599      -19     
+ Partials       70       68       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@gimlichael gimlichael merged commit c493047 into main Nov 12, 2025
168 of 169 checks passed
@gimlichael gimlichael deleted the v10.0.0/hotfix branch November 12, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants