V4.0.3/package maintenance #34
Conversation
|
""" WalkthroughThis update introduces version 4.0.3 across the project, focusing on dependency upgrades for all supported target frameworks and enhancements to AWS SQS message handling in the Savvyio.Extensions.SimpleQueueService namespace. It also updates various Docker and test environment images and improves documentation for several components. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant AmazonMessageReceiveOptions
participant AmazonMessage
participant AWS_SQS
App->>AmazonMessageReceiveOptions: Set VisibilityTimeout (default or custom)
App->>AmazonMessage: Receive messages (uses options)
AmazonMessage->>AWS_SQS: ReceiveMessageRequest (with VisibilityTimeout)
AWS_SQS-->>AmazonMessage: Response (messages or empty)
AmazonMessage-->>App: Yield messages (if any)
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
.docfx/Dockerfile.docfx (1)
6-6: Use COPY instead of ADD for local files
Hadolint DL3020 recommendsCOPYwhen simply copying context files. For example:- ADD [".", "docfx"] + COPY [".", "docfx"]🧰 Tools
🪛 Hadolint (2.12.0)
[error] 6-6: Use COPY instead of ADD for files and folders
(DL3020)
src/Savvyio.Extensions.SimpleQueueService/AmazonMessageReceiveOptions.cs (1)
17-45: Update constructor documentation to include new property.The constructor documentation table should include the new
VisibilityTimeoutproperty for completeness.Add the following entry to the property table:
/// <item> /// <term><see cref="UseApproximateNumberOfMessages"/></term> /// <description><c>false</c></description> /// </item> + /// <item> + /// <term><see cref="VisibilityTimeout"/></term> + /// <description>30 seconds</description> + /// </item>CHANGELOG.md (2)
15-16: Fix grammar in 'Changed' section
Use “includes” instead of “include” for singular class references (e.g., “AmazonMessageReceiveOptions class now includes…”).
22-23: Convert bare URLs to markdown links
Replace the raw AWS SDK and LinkedIn URLs with[text](url)syntax to satisfy MD034.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
22-22: Bare URL used
null(MD034, no-bare-urls)
23-23: Bare URL used
null(MD034, no-bare-urls)
.nuget/Savvyio.Extensions.SimpleQueueService/PackageReleaseNotes.txt (1)
8-8: Convert bare URL in bug fix to markdown link
Use[AWS SDK V4 collections guide](https://docs.aws.amazon.com/sdk-for-net/v4/developer-guide/net-dg-v4-collections)to satisfy MD034.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (39)
.docfx/Dockerfile.docfx(1 hunks).nuget/Savvyio.App/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Commands.Messaging/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Commands/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Core/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Domain.EventSourcing/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Domain/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.EventDriven.Messaging/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.EventDriven/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.Dapper/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DapperExtensions/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.Dapper/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.DapperExtensions/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.Domain/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSourcing/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.EFCore.Domain/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.EFCore/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.QueueStorage/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection.SimpleQueueService/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.DependencyInjection/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.Dispatchers/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.EFCore.Domain.EventSourcing/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.EFCore.Domain/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.EFCore/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.QueueStorage/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.SimpleQueueService/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Extensions.Text.Json/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Messaging/PackageReleaseNotes.txt(1 hunks).nuget/Savvyio.Queries/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(2 hunks)Dockerfile.localstack(1 hunks)docker-compose.yml(2 hunks)src/Savvyio.Extensions.QueueStorage/AzureQueueOptions.cs(1 hunks)src/Savvyio.Extensions.SimpleQueueService/AmazonMessage.cs(1 hunks)src/Savvyio.Extensions.SimpleQueueService/AmazonMessageOptions.cs(1 hunks)src/Savvyio.Extensions.SimpleQueueService/AmazonMessageReceiveOptions.cs(3 hunks)testenvironments.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/Savvyio.Extensions.SimpleQueueService/AmazonMessageReceiveOptions.cs (1)
src/Savvyio.Extensions.SimpleQueueService/AmazonMessageOptions.cs (3)
AmazonMessageOptions(16-141)AmazonMessageOptions(66-70)AmazonMessageOptions(99-108)
🪛 LanguageTool
.nuget/Savvyio.App/PackageReleaseNotes.txt
[duplication] ~5-~5: Possible typo: you repeated a word.
Context: ...ity: .NET 9 and .NET 8 # References - Savvyio - Savvyio.Commands - Savvyio.Commands.Messaging -...
(ENGLISH_WORD_REPEAT_RULE)
🪛 Hadolint (2.12.0)
.docfx/Dockerfile.docfx
[error] 6-6: Use COPY instead of ADD for files and folders
(DL3020)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
22-22: Bare URL used
null
(MD034, no-bare-urls)
23-23: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (70)
src/Savvyio.Extensions.QueueStorage/AzureQueueOptions.cs (4)
48-49: Approve documentation for StorageAccountName default valueThe
StorageAccountNameentry has been correctly added to the remarks table with its initial value ofnull, accurately reflecting the default state upon instantiation.
50-51: Approve documentation for Settings default valueThe
Settingsentry with defaultnew QueueClientOptions()is properly documented in the initial values table.
55-57: Approve documentation for ReceiveContext default valueThe
ReceiveContextdefault ofnew AzureQueueReceiveOptions()is now clearly documented, enhancing clarity around the constructor behavior.
58-61: Approve documentation for SendContext default valueThe
SendContextdefaultnew AzureQueueSendOptions()entry correctly covers the initial state and improves the XML remarks..nuget/Savvyio.Extensions.DependencyInjection.Domain/PackageReleaseNotes.txt (1)
1-5: Validate new release notes entry for 4.0.3
The addition correctly declares Version 4.0.3 with Availability .NET 9 and .NET 8 and an ALM note describing the dependency upgrades. This matches the release notes pattern used elsewhere..nuget/Savvyio.Domain/PackageReleaseNotes.txt (1)
1-5: Approve version bump to 4.0.3
The release notes entry properly adds Version 4.0.3, targets .NET 9 and .NET 8, and notes the upgraded dependencies. Consistent with the broader package maintenance effort..nuget/Savvyio.Messaging/PackageReleaseNotes.txt (1)
1-5: Approve new release note for 4.0.3
Entry correctly reflects the version bump to 4.0.3, framework availability, and dependency upgrade ALM note. Aligns with other Savvyio packages in this release..nuget/Savvyio.EventDriven/PackageReleaseNotes.txt (1)
1-5: Confirm release notes addition for 4.0.3
Version 4.0.3 is properly documented with .NET 9/.NET 8 support and an ALM change for dependency updates. Consistent formatting and content..nuget/Savvyio.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-5: Approve release notes update for 4.0.3
The new entry accurately documents Version 4.0.3, availability on .NET 9 and .NET 8, and the dependency upgrade ALM note. Matches the style of other package release notes..nuget/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSourcing/PackageReleaseNotes.txt (2)
5-5: Confirm release note phrasing consistency.The phrasing “upgraded to the latest compatible versions for all supported target frameworks (TFMs)” is clear and formal. Please ensure this wording is used uniformly across all package release notes for the 4.0.3 release.
1-2:Details
❓ Verification inconclusive
Approve version bump and TFM availability.
The new entry for version 4.0.3 targeting .NET 9 and .NET 8 correctly reflects the PR objectives. Ensure that the corresponding project files and the central versioning props have been updated to match this version.
Run the following script to verify version 4.0.3 across all project and props files:
🏁 Script executed:
#!/bin/bash # Verify version 4.0.3 in all .csproj and Directory.Packages.props fd -e csproj -e props | xargs grep -H "Version>4.0.3<"Length of output: 56
I couldn’t find any explicit
<Version>4.0.3</Version>entries with the previous pattern. Let’s do a broader search for “4.0.3” in all project and props files to confirm:
🏁 Script executed:
#!/bin/bash # Broader search for version 4.0.3 in .csproj and .props grep -R "4\.0\.3" -n --include="*.csproj" --include="*.props" .Length of output: 65
Unable to locate version 4.0.3 in project or props files
I ran a recursive search across all *.csproj and *.props files but found no references to “4.0.3.” Please manually verify that:
- All <Version> or <VersionPrefix> entries in your .csproj files have been updated to 4.0.3
- The central Directory.Packages.props (or equivalent) reflects version 4.0.3
.nuget/Savvyio.Extensions.Text.Json/PackageReleaseNotes.txt (2)
5-5: Confirm release note phrasing consistency.The updated line “Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs)” is precise. Ensure this phrasing is mirrored across all 4.0.3 release notes.
1-2:Details
❓ Verification inconclusive
Approve version bump and TFM availability.
Version 4.0.3 targeting .NET 9 and .NET 8 aligns with the release objectives. Verify that all relevant project files and the central props file reflect this version update.
🏁 Script executed:
#!/bin/bash # Verify version 4.0.3 in all .csproj and Directory.Packages.props fd -e csproj -e props | xargs grep -H "Version>4.0.3<"Length of output: 56
🏁 Script executed:
#!/bin/bash # Verify <Version>4.0.3</Version> across all .csproj and Directory.Packages.props files fd -e csproj -e props | xargs grep -H "<Version>4\.0\.3</Version>" # Verify that each project file supports net8.0 and net9.0 TFMs fd -e csproj | xargs grep -H -E "<TargetFramework>net(8\.0|9\.0)</TargetFramework>"Length of output: 154
#!/bin/bash # Search for version 4.0.3 in .csproj and .props files fd -e csproj -e props | xargs rg -n "4\.0\.3" # Search for version 4.0.3 anywhere in the repo rg -n "4\.0\.3" # Search for net8.0 and net9.0 TFMs in project files rg -n -e "net8\.0" -e "net9\.0"
Approve version bump and TFM availability – please verify project files
Version 4.0.3 targeting .NET 9 and .NET 8 aligns with our release objectives. Before merging, manually confirm that:
- Every
*.csprojfile has been updated to<Version>4.0.3</Version>.- Each project that should target .NET 8 or .NET 9 declares
<TargetFramework>net8.0</TargetFramework>and/or<TargetFramework>net9.0</TargetFramework>.Directory.Packages.props(or any central props) contains<Version>4.0.3</Version>..nuget/Savvyio.Extensions.DependencyInjection.DapperExtensions/PackageReleaseNotes.txt (1)
5-5: Confirm release note phrasing consistency.Using “upgraded to the latest compatible versions for all supported target frameworks (TFMs)” is clear and matches the updated style. Make sure this is consistent across every 4.0.3 package release note.
.nuget/Savvyio.Commands.Messaging/PackageReleaseNotes.txt (2)
5-5: Confirm release note phrasing consistency.The release note now reads “Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs)”. Ensure this improved wording is applied across all affected packages for this release.
1-2:Details
❓ Verification inconclusive
Approve version bump and TFM availability.
The new version 4.0.3 entry specifying .NET 9 and .NET 8 support is on target. Verify that all project files and central version props reflect this change.
🏁 Script executed:
#!/bin/bash # Verify version 4.0.3 in all .csproj and Directory.Packages.props fd -e csproj -e props | xargs grep -H "Version>4.0.3<"Length of output: 56
Let’s broaden the search to catch all instances of the new version and TFMs in project files:
🏁 Script executed:
#!/bin/bash # 1) Find any “4.0.3” occurrences in .csproj or .props grep -R -n "4\.0\.3" --include \*.csproj --include \*.props . # 2) Confirm net8.0 and net9.0 are listed in TargetFramework(s) grep -R -n "<TargetFrameworks>.*net8\.0.*net9\.0" --include \*.csproj .Length of output: 140
Verify version bump and target frameworks in project files
I ran searches for “4.0.3” (including
<Version>4.0.3</Version>) and fornet8.0/net9.0TFMs in all.csprojand.propsfiles and found no matches. Please manually verify that:
Directory.Packages.props(or any central version props file) is updated to version 4.0.3.- Individual
.csprojfiles include<Version>4.0.3</Version>if they declare versions locally.- Each project’s
<TargetFramework>or<TargetFrameworks>list includes bothnet8.0andnet9.0..nuget/Savvyio.Extensions.Dapper/PackageReleaseNotes.txt (2)
5-5: Confirm release note phrasing consistency.The change log line “Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs)” reads well and is more formal. Ensure this phrasing is uniform across all 4.0.3 notes.
1-2:Details
❓ Verification inconclusive
Approve version bump and TFM availability.
Updating to version 4.0.3 with .NET 9 and .NET 8 availability matches the PR goals. Please confirm that the version is consistently updated in all project and props files.
🏁 Script executed:
#!/bin/bash # Verify version 4.0.3 in all .csproj and Directory.Packages.props fd -e csproj -e props | xargs grep -H "Version>4.0.3<"Length of output: 56
🏁 Script executed:
#!/bin/bash # Search for explicit <Version>4.0.3</Version> across all .csproj and Directory.Packages.props files find . -type f \( -name "*.csproj" -o -name "Directory.Packages.props" \) -print0 \ | xargs -0 grep -H -E "<Version>4\.0\.3</Version>"Length of output: 134
Confirm version bump consistency
I wasn’t able to find any reference to version 4.0.3 in your
.csprojorDirectory.Packages.propsfiles. Please manually verify that every project and package reference has been updated to 4.0.3. For example, check for:
<Version>4.0.3</Version><VersionPrefix>4.0.3</VersionPrefix>Version="4.0.3"Once confirmed across all files, we can approve the bump and TFM availability.
.nuget/Savvyio.Extensions.DapperExtensions/PackageReleaseNotes.txt (2)
1-2: Version bump to 4.0.3 is correct
The new release entry accurately reflects version 4.0.3 targeting .NET 9 and .NET 8.
5-5: Release notes entry is clear and consistent
The “CHANGED Dependencies have been upgraded…” line is well-phrased and matches the convention used across other packages..docfx/Dockerfile.docfx (3)
1-2: Explicit multi-platform build directive
Adding--platform=$BUILDPLATFORMto the base image ensures correct multi-arch support.
4-4: DocFX builder image version upgrade
Upgrading tocodebeltnet/docfx:2.78.3aligns with the project’s dependency maintenance.
11-12: Align final image version with base stage
Switching the final stage tonginx:1.27.5-alpinekeeps the runtime consistent.Dockerfile.localstack (1)
2-2: Update LocalStack image to 4.4.0
Bumping from 4.3.0 to 4.4.0 brings in the latest fixes and features. Confirm there are no breaking changes for your initialization scripts.testenvironments.json (1)
12-12: Bump Docker-Ubuntu test runner image
Updating togimlichael/ubuntu-testrunner:net8.0.409-9.0.300aligns with the .NET 8/9 upgrade. Verify that this tag is published and includes the expected runtimes..nuget/Savvyio.Extensions.DependencyInjection.EFCore.Domain/PackageReleaseNotes.txt (2)
1-2: Version bump to 4.0.3 is accurate
New entry correctly notes version 4.0.3 support for .NET 9 and .NET 8.
5-5: Dependency upgrade note is clear
The “CHANGED Dependencies have been upgraded…” line matches the style used across other package release notes..nuget/Savvyio.EventDriven.Messaging/PackageReleaseNotes.txt (2)
1-2: Version bump and target frameworks updated
The package version and availability for .NET 9 and .NET 8 have been correctly updated to align with the PR objectives.
4-5: ALM changelog entry is clear and consistent
The ALM section documents the dependency upgrade using the same phrasing and format as other packages in this release..nuget/Savvyio.Extensions.EFCore/PackageReleaseNotes.txt (2)
1-2: Version bump and target frameworks updated
Consistent version 4.0.3 for .NET 9 and .NET 8 is correctly reflected.
4-5: ALM changelog entry is clear and consistent
Dependencies upgrade entry follows the project-wide convention..nuget/Savvyio.Extensions.EFCore.Domain.EventSourcing/PackageReleaseNotes.txt (2)
1-2: Version bump and target frameworks updated
The new version 4.0.3 and TFMs (.NET 9, .NET 8) are correctly specified.
4-5: ALM changelog entry is clear and consistent
The dependency upgrade description matches the standard ALM format..nuget/Savvyio.Commands/PackageReleaseNotes.txt (2)
1-2: Version bump and target frameworks updated
Version 4.0.3 and availability for .NET 9 and .NET 8 are correctly applied.
4-5: ALM changelog entry is clear and consistent
Use of the CHANGED ALM bullet aligns with other package notes..nuget/Savvyio.Core/PackageReleaseNotes.txt (2)
1-2: Version bump and target frameworks updated
The package has been updated to 4.0.3 with .NET 9 and .NET 8 support as intended.
4-5: ALM changelog entry is clear and consistent
The dependencies upgrade entry uses consistent wording with the release..nuget/Savvyio.Extensions.DependencyInjection.SimpleQueueService/PackageReleaseNotes.txt (1)
1-6: Release notes entry for 4.0.3 is accurate.
Version, target frameworks, and ALM description correctly document the dependency upgrade for .NET 9 and .NET 8..nuget/Savvyio.Extensions.QueueStorage/PackageReleaseNotes.txt (1)
1-6: QueueStorage package bump to 4.0.3 looks good.
The new version entry correctly lists .NET 9 and .NET 8 support and clearly states the dependency upgrade under ALM..nuget/Savvyio.Extensions.DependencyInjection.EFCore/PackageReleaseNotes.txt (1)
1-6: EFCore DI release notes updated properly.
The 4.0.3 section accurately specifies .NET 9 and .NET 8 availability and notes the dependency upgrade for all supported TFMs..nuget/Savvyio.App/PackageReleaseNotes.txt (1)
1-30: App package release notes reflect 4.0.3 correctly.
The new section lists .NET 9 and .NET 8 frameworks and includes a comprehensive set of references for this coordinated release.🧰 Tools
🪛 LanguageTool
[duplication] ~5-~5: Possible typo: you repeated a word.
Context: ...ity: .NET 9 and .NET 8 # References - Savvyio - Savvyio.Commands - Savvyio.Commands.Messaging -...(ENGLISH_WORD_REPEAT_RULE)
.nuget/Savvyio.Extensions.EFCore.Domain/PackageReleaseNotes.txt (1)
1-6: EFCore.Domain notes are consistent.
Version, availability, and ALM description for 4.0.3 properly document the dependency upgrades across target frameworks.docker-compose.yml (2)
3-3: Verify LocalStack image upgrade compatibilityYou’ve bumped LocalStack from
4.3.0to4.4.0. Please confirm that:
- All existing service health checks still pass.
- No breaking changes in LocalStack v4.4.0 affect your test scripts or infrastructure.
13-13: Validate AWS CLI image versionThe AWS CLI image was updated from
2.26.4to2.27.22. Ensure that:
- All AWS CLI commands (especially the SQS/SNS creation commands) still work as expected.
- No new defaults or behavioral changes in v2.27.22 impact your CI/CD workflows.
.nuget/Savvyio.Extensions.DependencyInjection.Dapper/PackageReleaseNotes.txt (1)
1-6:Details
✅ Verification successful
Ensure all release notes are consistently versioned
Release notes have been updated to
Version: 4.0.3with an ALM entry for dependency upgrades. Please run this script to verify that everyPackageReleaseNotes.txtin.nuget/is bumped to 4.0.3:
🏁 Script executed:
#!/bin/bash # Description: Check that all PackageReleaseNotes.txt files reference version 4.0.3 missing=$(find .nuget -name PackageReleaseNotes.txt -exec grep -L 'Version: 4\.0\.3' {} +) if [ -n "$missing" ]; then echo "❌ The following release notes files are missing version 4.0.3:" $missing exit 1 fi echo "✅ All release notes files are correctly updated to 4.0.3."Length of output: 236
All release notes files updated to Version 4.0.3
Verified that every.nuget/**/PackageReleaseNotes.txtnow referencesVersion: 4.0.3. ✅.nuget/Savvyio.Extensions.DependencyInjection/PackageReleaseNotes.txt (1)
1-6: Release notes updated for DependencyInjection (v4.0.3)Version and ALM entry correctly reflect the dependency upgrade for .NET 8 and .NET 9 targets.
.nuget/Savvyio.Extensions.DependencyInjection.QueueStorage/PackageReleaseNotes.txt (1)
1-6: Release notes updated for QueueStorage (v4.0.3)The version bump and ALM description accurately document the dependency upgrade.
.nuget/Savvyio.Queries/PackageReleaseNotes.txt (1)
1-6: Release notes updated for Queries (v4.0.3)Version and ALM entry are consistent with other packages.
.nuget/Savvyio.Domain.EventSourcing/PackageReleaseNotes.txt (1)
1-6: LGTM! Clear improvement in release documentation.The version 4.0.3 entry is well-formatted and the revised dependency upgrade language ("Dependencies have been upgraded to the latest compatible versions for all supported target frameworks") is clearer and more precise than the previous phrasing.
.nuget/Savvyio.Extensions.Dispatchers/PackageReleaseNotes.txt (1)
1-6: LGTM! Consistent package maintenance update.The version 4.0.3 entry maintains consistency with other Savvyio packages and uses the improved, clearer language for dependency upgrades.
src/Savvyio.Extensions.SimpleQueueService/AmazonMessage.cs (2)
127-128: LGTM! Proper visibility timeout configuration.The addition of
VisibilityTimeoutto theReceiveMessageRequestcorrectly uses the new configuration option and properly converts the TimeSpan to seconds as required by the AWS SDK.
132-132: LGTM! Essential AWS SDK v4 compatibility fix.The null check for
response.Messagesis necessary for AWS SDK v4 compatibility, where collections default to null instead of empty collections. This defensive programming approach prevents potential NullReferenceExceptions.src/Savvyio.Extensions.SimpleQueueService/AmazonMessageReceiveOptions.cs (3)
11-11: LGTM! Consistent field declaration.The private field follows the established naming convention and pattern used by other properties in the class.
50-50: LGTM! Proper initialization with default value.The constructor correctly initializes the VisibilityTimeout with the default value from
AmazonMessageOptions.DefaultVisibilityTimeoutInSeconds.
78-87: LGTM! Well-implemented property with proper validation.The VisibilityTimeout property follows the same pattern as other properties in the class:
- Uses Math.Clamp for validation within AWS SQS limits (0 to 43,200 seconds)
- Proper XML documentation with default value and constraints
- Consistent with AWS SQS visibility timeout specifications
src/Savvyio.Extensions.SimpleQueueService/AmazonMessageOptions.cs (3)
24-26: Approve reworded XML doc for MaxPollingWaitTimeInSeconds
The updated summary improves clarity around the polling wait time for SQS. It aligns with AWS documentation.
28-31: Add MaxVisibilityTimeoutInSeconds constant
IntroducingMaxVisibilityTimeoutInSeconds = 12 * 60 * 60correctly represents the AWS SQS maximum visibility timeout (12 hours).
33-36: Add DefaultVisibilityTimeoutInSeconds constant
DefiningDefaultVisibilityTimeoutInSeconds = 30provides a sensible default (30 s) matching the SQS default visibility timeout.Directory.Packages.props (8)
7-8: Upgrade AWS SDK packages to v4.0.0.4
Aligns with your code changes supporting AWS SDK v4 for SQS and SNS.
9-10: Upgrade Azure SDK packages
Azure.Identity → 1.14.0 and Azure.Messaging.EventGrid → 4.31.0. Please verify any breaking changes in EventGrid v4.x if used.
12-14: Upgrade Codebelt.Extensions packages
Bumping Newtonsoft.Json, Xunit.App, and YamlDotNet extensions to 9.x/10.x for alignment with other dependencies.
15-21: Upgrade Cuemon.Extensions packages
All Cuemon extension libraries moved to version 9.0.5—consistent and expected.
24-26: Upgrade Sqlite and test tooling packages
Microsoft.Data.Sqlite → 9.0.5, Microsoft.NET.Test.Sdk/ObjectModel → 17.14.0. These align with .NET 8/9 support.
35-35: Upgrade xunit.runner.visualstudio to 3.1.0
Ensures compatibility with the updated test SDK and Visual Studio adapter.
38-41: Upgrade EF Core packages for .NET 9
Microsoft.EntityFrameworkCore packages bumped to 9.0.5—matches the target framework upgrade.
44-46: Upgrade EF Core packages for .NET 8
Microsoft.EntityFrameworkCore packages bumped to 8.0.16—consistent with multi-TFM support.CHANGELOG.md (1)
7-9: Add changelog entry for v4.0.3
The new header and summary line correctly document the 2025-05-28 release..nuget/Savvyio.Extensions.SimpleQueueService/PackageReleaseNotes.txt (3)
1-2: Update release notes to v4.0.3
Version and availability headers correctly reflect the .NET 8/9 release.
5-5: Document upgraded dependencies
The note on central dependency upgrades accurately summarizes the changes.
11-12: Document visibility timeout improvements
The improvements section clearly describes the addition ofVisibilityTimeoutand the new constants.
| Version: 4.0.3 | ||
| Availability: .NET 9 and .NET 8 |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Approve version bump and TFM availability.
The entry for version 4.0.3 with support for .NET 9 and .NET 8 is correct. Please confirm that project metadata and Directory.Packages.props have been updated accordingly.
🏁 Script executed:
#!/bin/bash
# Verify version 4.0.3 in all .csproj and Directory.Packages.props
fd -e csproj -e props | xargs grep -H "Version>4.0.3<"Length of output: 56
🏁 Script executed:
#!/bin/bash
# Search for any mention of version 4.0.3 in all .csproj and props files
fd -e csproj -e props | xargs grep -H "4.0.3"
# Verify that TargetFrameworks include net8.0 and net9.0
fd -e csproj | xargs grep -H "<TargetFrameworks>" -A1
fd -e csproj | xargs grep -H "net8.0"
fd -e csproj | xargs grep -H "net9.0"Length of output: 177
Update project metadata for version 4.0.3 and .NET 8/9 support
Our grep across all .csproj and Directory.Packages.props files did not locate any references to 4.0.3, net8.0, or net9.0. Please apply the following fixes:
- In
Directory.Packages.props(root), set the package’s version to:<Version>4.0.3</Version>
- In each relevant
.csproj:- Update
<Version>(or<PackageVersion>) to4.0.3. - Ensure
<TargetFrameworks>includes bothnet8.0andnet9.0, for example:<TargetFrameworks>netstandard2.0;net8.0;net9.0</TargetFrameworks>
- Update
🤖 Prompt for AI Agents
In the root Directory.Packages.props file and all relevant .csproj files, update
the package version to 4.0.3 by setting the <Version> or <PackageVersion> tag
accordingly. Additionally, ensure that the <TargetFrameworks> tag in each
.csproj includes both net8.0 and net9.0 alongside existing frameworks, for
example: netstandard2.0;net8.0;net9.0. This will align the project metadata with
the version bump and new target framework support stated in the release notes.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/pipelines.yml (2)
86-94: 🧪 Functional Test Job Configuration Approved
Theintegration_testjob cleanly separates functional tests with its own matrix. Consider as an optional refactor switching the inline array to a block-style YAML list for improved readability:- project: [ test/**/Savvyio.FunctionalTests.csproj, Savvyio.Extensions.SimpleQueueService.FunctionalTests.csproj, Savvyio.Extensions.QueueStorage.FunctionalTests.csproj ] + project: + - test/**/Savvyio.FunctionalTests.csproj + - test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.csproj + - test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj
43-43: ✂️ Remove Trailing Whitespace
Static analysis flagged trailing spaces on lines 43 and 99. These spaces are no-ops but can clutter diffs. Please remove them:- !test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj␣ + !test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj - uses: codebeltnet/git-checkout@v1␣ + uses: codebeltnet/git-checkout@v1Also applies to: 99-99
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 43-43: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pipelines.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/pipelines.yml
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (198)
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.Tests/Savvyio.Exten... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.Tests/Savvyio.Exten... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.Tests/Savvyio.Exten... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.Tests/Savvyio.Assets.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extensio... / 🧪 Test
🔇 Additional comments (9)
.github/workflows/pipelines.yml (9)
25-36: 📜 Modular Prepare Test Job Extraction Looks Good
Splitting out theprepare_testjob to generate a JSON matrix viashell-globbing@v2significantly improves readability and reusability. The outputs declaration is correct and integrates cleanly with downstream jobs.
38-42: ✅ Test Project Globbing Patterns Are Correct
The include/exclude glob patterns properly target all unit tests undertest/**/*.csprojwhile omitting the functional test projects. This ensures the matrix will only run true unit tests.
44-45: 👍 JSON Output Step for Debugging
Echoing the matrix JSON is a simple yet effective way to verify the list of test projects at runtime.
48-56: 🔧 Reusable Build Job Invocation Approved
Delegating the build steps to thejobs-dotnet-buildreusable workflow with a configuration matrix and passing the strong-name key is concise and maintains consistency across pipelines.
59-68: 🔧 Reusable Pack Job Invocation Approved
Thecall-packjob correctly awaits the build output, uses the pack workflow, and passes the version output for artifact uploads. Clear and maintainable.
71-79: ✅ Unit Test Job Declaration Approved
Thecall-testjob header with dependencies onbuildandprepare_test, combined with a matrix over OS, configuration, and project list, is well-structured for parallel test execution.
80-84: ✅ Unit Test Workflow Inputs Mapping
Inputs (runs-on,configuration,projects, andbuild-switches) tojobs-dotnet-testare correctly wired. The skip-sign-assembly switch is passed as intended.
100-101: ⬆️ .NET Installer Updated to v2
Upgrading toinstall-dotnet@v2in the functional test job aligns with the build and test workflows. Good catch on version consistency.
155-156: 🚀 NuGet Deploy Job Invocation Approved
Thecall-nugetjob now leverages the reusablejobs-nuget-pushworkflow with proper dependencies on all preceding jobs. Deployment gating on non-PR events is correctly maintained.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 89.54% 86.69% -2.85%
==========================================
Files 158 158
Lines 3289 3284 -5
Branches 331 332 +1
==========================================
- Hits 2945 2847 -98
- Misses 342 435 +93
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/pipelines.yml (3)
25-29: Rename and clarify theprepare_testjob and output variableThe job has been renamed from
preparetoprepare_test, and the output key changed fromtestProjectstojson. Ensure that all downstream jobs consistently consume${{ needs.prepare_test.outputs.json }}. For improved readability, consider using a more descriptive output name such astestMatrixJson.
86-94: Introduceintegration_testjob for functional test projectsAdding a dedicated
integration_testjob that runs the three functional test projects across both Linux and Windows is a solid enhancement. Consider renaming the display name (e.g.,🧪 Integration Tests) to clearly distinguish it from the unit-test job.
43-43: Remove trailing whitespaceLines 43, 99, and 145 have trailing spaces, which triggers
.yamllinterrors. Please delete the extra spaces at the ends of these lines.Also applies to: 99-99, 145-145
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 43-43: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pipelines.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/pipelines.yml
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
[error] 145-145: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (161)
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DependencyInjection.Tests/Savvyio.Exten... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Di... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.Dapper.Tests/Savvyio.Assets.Dapper.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.Dispatchers.Tests/Savvyio.Extensions.Disp... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Dapper.Tests/Savvyio.Extensions.Dapper.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.Te... / 🧪 Test
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
🔇 Additional comments (12)
.github/workflows/pipelines.yml (12)
36-42: Upgrade shell-globbing to v2 with refined test patternsSwitching to
codebeltnet/shell-globbing@v2and explicitly excluding the three functional test projects will streamline matrix generation and avoid unintended test runs—great improvement.
44-45: Preserve JSON output of test-projectsThe
echostep surfaces the generated JSON for downstream matrix consumption. This is helpful for debugging and is required for the subsequentfromJsoncall.
48-48: Renamebuildjob tocall-buildChanging the job name to
call-buildaligns with the naming convention used for reusable workflow invocations.
52-56: Convert inline build steps to reusable workflowInvoking
jobs-dotnet-buildas a reusable workflow standardizes the build across repositories. The provided inputs (configurationandstrong-name-key-filename) look correct.
59-60: Renamepackjob tocall-packand add dependencyRenaming the
packjob tocall-packand ensuring it depends onbuildaligns it with the broader reusable-workflow pattern.
64-68: Invokejobs-dotnet-packreusable workflowMoving packaging logic into
jobs-dotnet-packwith theupload-packed-artifactandversionparameters simplifies maintenance and artifact management.
71-84: Use reusable workflow for test matrix executionThe
call-testjob now leveragesjobs-dotnet-testwith a matrix of OS, configuration, and dynamically generated projects. This greatly improves clarity and maintainability of test runs.
101-101: Upgrade.NETinstaller action to v2Switching to
codebeltnet/install-dotnet@v2ensures better multi-SDK support for .NET 8 and .NET 9.
130-130: Ensuresonarcloudruns after integration testsAdding
integration_testto theneedslist guarantees that all functional test artifacts are available prior to SonarCloud analysis.
140-140: Include integration tests incodecovjob dependencyRequiring
integration_testbeforecodecovensures coverage data from functional tests is uploaded correctly.
148-148: Run CodeQL after integration testsAdding
integration_testas a prerequisite forcodeqlhelps incorporate functional-test artifacts into security analysis.
156-157: Gatedeployjob on integration tests and use reusable NuGet pushThe
deployjob now waits forintegration_testand invokesjobs-nuget-push—this aligns with the CI conventions established above.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/pipelines.yml (2)
25-29: Clarifyprepare_testjob output naming
The job now emits an output calledjson. Consider renaming it to something more descriptive (e.g.,test_matrixorprojects_json) to improve readability in downstream references.
43-43: Remove trailing whitespace
YAMLlint flagged trailing spaces on these lines. Please remove the extra spaces to satisfy the linter.Also applies to: 99-99, 145-145
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 43-43: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pipelines.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/pipelines.yml
[error] 43-43: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
[error] 145-145: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (178)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.EFCore.Tests/Savvyio.Extensions.EFCore.Te... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSou... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.Tests/S... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Commands.Tests/Savvyio.Commands.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.SimpleQueueService.FunctionalTests.c...
- GitHub Check: 🧪 Test (windows-2022, Release, test/**/Savvyio.Extensions.QueueStorage.FunctionalTests.csproj)
🔇 Additional comments (8)
.github/workflows/pipelines.yml (8)
36-42: Approve shell-globbing pattern for test matrix
Upgrading tocodebeltnet/shell-globbing@v2and excluding functional tests from the unit-test matrix is correct and aligns with the new integration test strategy.
44-45: Approve JSON output logging step
Echoing the JSON payload for the test matrix aids debugging without affecting the workflow output.
48-56: Verify availability of strong-name key file
You’re passingstrong-name-key-filename: savvyio.snkinto the reusable build workflow. Please confirm thatsavvyio.snkis present at the workspace root (or adjust the path) so the build won’t fail.
59-68: Approvepackjob reusable workflow
Switching tojobs-dotnet-packwith theversionsourced from build outputs and uploading the packed artifact looks correct.
71-83: Verify inputs for reusable test workflow
You’re invokingjobs-dotnet-testwith inputs such asruns-on,configuration,projects, andbuild-switches. Please ensure the external workflow defines matching input parameters (e.g., it expectsruns-onrather thanruns_on).
86-94: Approveintegration_testjob configuration
Defining a separate integration test job with a Release-only matrix and explicit functional-test projects is a solid approach to segregate fast unit tests from slower E2E scenarios.
101-101: Approve upgrade toinstall-dotnet@v2
Switching to the v2 installer action ensures better multi-platform support and aligns with the multi-arch base images used elsewhere.
130-131: Approve inclusion ofintegration_testas a dependency
Addingintegration_testto the dependencies of sonarcloud, codecov, codeql, and deploy jobs guarantees that functional tests are run and accounted for before code analysis and package publishing.Also applies to: 142-143, 148-149, 156-157
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
test/Savvyio.FunctionalTests/DistributedMediatorTest.cs (2)
45-45: Consider making the platform detection more explicit.The platform detection logic is correct, but consider adding a comment explaining why platform-specific behavior is needed in these functional tests.
+ // Platform-specific email addresses to avoid conflicts when running tests in parallel across different OS in CI/CD private static readonly bool IsLinux = RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
70-70: Refactor duplicated platform-specific email logic.The conditional email assignment logic is duplicated in two places. Consider extracting this to a constant or helper method to improve maintainability and reduce code duplication.
Extract the email logic to a constant at the class level:
private static readonly bool IsLinux = RuntimeInformation.IsOSPlatform(OSPlatform.Linux); + private static readonly string PlatformSpecificEmail = IsLinux ? "[email protected]" : "[email protected]";Then replace both occurrences:
- var emailAddress = IsLinux ? "[email protected]" : "[email protected]"; + var emailAddress = PlatformSpecificEmail;- var expectedEmailAddress = IsLinux ? "[email protected]" : "[email protected]"; + var expectedEmailAddress = PlatformSpecificEmail;Also applies to: 136-137
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
test/Savvyio.FunctionalTests/DistributedMediatorTest.cs(5 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
test/Savvyio.FunctionalTests/DistributedMediatorTest.cs (1)
test/Savvyio.Assets.Tests/Domain/EmailAddress.cs (1)
EmailAddress(13-17)
⏰ Context from checks skipped due to timeout of 90000ms (158)
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.SimpleQueueService.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Q... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.EFCore.Domain.EventSo... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Que... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyio.... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Que... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Que... / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.QueueStorage.Tests/Savvyio.Extensions.Que... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensions... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Queries.Tests/Savvyio.Queries.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Assets.EfCore.Tests/Savvyio.Assets.EfCore.Tests.cs... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DependencyInjection.Dapper.Tests/Savvyi... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Extensions.DependencyInjection.DapperExtensions.Test... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.EventSourcing.Tests/Savvyio.Domain.EventSourc... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.Text.Json.Tests/Savvyio.Extensions.Text... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Core.Tests/Savvyio.Core.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.SimpleQueueService.Tests/Savvyio.Extens... / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.EventDriven.Tests/Savvyio.EventDriven.Tests.csproj) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release, test/Savvyio.Extensions.DapperExtensions.Tests/Savvyio.Extensio... / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug, test/Savvyio.Domain.Tests/Savvyio.Domain.Tests.csproj) / 🧪 Test
🔇 Additional comments (2)
test/Savvyio.FunctionalTests/DistributedMediatorTest.cs (2)
1-1: LGTM: Import additions support platform detection.The new imports are properly added to support the platform detection functionality, particularly
System.Runtime.InteropServiceswhich is required for theRuntimeInformation.IsOSPlatformcall.Also applies to: 6-8, 33-36
70-70: Verify the purpose of platform-specific email addresses.While the implementation is correct, using platform-specific email addresses in functional tests introduces test environment dependencies. Ensure this approach aligns with your testing strategy and doesn't create unnecessary complexity.
Consider documenting why platform-specific emails are needed. Are they used to:
- Avoid conflicts when running tests in parallel on different platforms?
- Test platform-specific AWS SQS behavior?
- Isolate test data across different CI/CD environments?
Understanding the rationale will help maintain these tests effectively.
Also applies to: 136-137
|
This pull request includes updates to the Dockerfile for DocFX and various package release notes to reflect dependency upgrades and new versioning. The most important changes involve improving compatibility and ensuring the latest versions of dependencies are used across multiple packages.
Dockerfile Update:
.docfx/Dockerfile.docfx: Updated the base and build images to include the--platform=$BUILDPLATFORMdirective and upgraded to newer versions ofnginx(1.27.5-alpine) anddocfx(2.78.3). This change enhances compatibility and ensures the build process supports multi-platform environments.Package Release Notes Updates:
4.0.3across multiple packages, with all changes highlighting upgraded dependencies to the latest compatible versions for .NET 9 and .NET 8 target frameworks. These updates ensure better compatibility and performance:.nuget/Savvyio.App/PackageReleaseNotes.txt.nuget/Savvyio.Commands/PackageReleaseNotes.txt.nuget/Savvyio.Commands.Messaging/PackageReleaseNotes.txt.nuget/Savvyio.Domain.EventSourcing/PackageReleaseNotes.txt.nuget/Savvyio.Extensions.Dapper/PackageReleaseNotes.txtThese changes collectively enhance the project's maintainability and ensure alignment with the latest platform standards.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores