V4.2.0/support for nats #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Warning Rate limit exceeded@gimlichael has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 34 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (107)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces comprehensive NATS integration support for the Savvy I/O framework, adding both NATS Work-Queue Stream (for commands) and NATS Core Publish-Subscribe (for integration events) capabilities. The PR also includes dependency updates across the entire project and improvements to CI/CD infrastructure.
- Added new NATS extension packages with full command queue and event bus implementations
- Updated all package dependencies to their latest compatible versions for supported target frameworks
- Enhanced CI/CD pipeline with NATS integration testing support
Reviewed Changes
Copilot reviewed 107 out of 109 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/Savvyio.Extensions.NATS/* |
Core NATS integration package with base classes, command queue, and event bus implementations |
src/Savvyio.Extensions.DependencyInjection.NATS/* |
Dependency injection extensions for NATS with generic marker support |
test/Savvyio.Extensions.NATS.*Tests/* |
Comprehensive unit and functional tests for NATS functionality |
Directory.Packages.props |
Package dependency updates across all supported target frameworks |
.nuget/*/ |
Updated documentation and release notes for all packages to version 4.2.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...Savvyio.Extensions.NATS.FunctionalTests/EventDriven/NatsEventBusJsonSerializerContextTest.cs
Show resolved
Hide resolved
src/Savvyio.Extensions.DependencyInjection.NATS/EventDriven/NatsEventBus.cs
Outdated
Show resolved
Hide resolved
src/Savvyio.Extensions.DependencyInjection.NATS/Commands/NatsCommandQueue.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…tsEventBus.cs Co-authored-by: Copilot <[email protected]>
…ommandQueue.cs Co-authored-by: Copilot <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 75.59% 74.81% -0.79%
==========================================
Files 167 175 +8
Lines 3483 3633 +150
Branches 348 360 +12
==========================================
+ Hits 2633 2718 +85
- Misses 848 913 +65
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for NATS integration, upgrades dependencies across multiple packages, and updates documentation and CI/CD pipelines accordingly. The main highlights are the addition of NATS-related projects, improved pipeline coverage for NATS integration tests, and the bump of several dependencies to their latest compatible versions.
NATS Integration Support:
Savvyio.Extensions.DependencyInjection.NATSandSavvyio.Extensions.NATSto project references in.docfx/docfx.jsonand listed them in multiple README files for documentation and discoverability. [1] [2] [3] [4] [5] [6] [7]Dependency and Release Management:
Savvyio.App,Savvyio.Commands.Messaging,Savvyio.Commands,Savvyio.Core,Savvyio.Domain.EventSourcing,Savvyio.Domain,Savvyio.EventDriven.Messaging) to version 4.2.0, indicating upgrades to the latest compatible dependencies for all supported TFMs. [1] [2] [3] [4] [5] [6] [7]CI/CD Pipeline Enhancements:
Docker and Build Improvements:
.docfx/Dockerfile.docfxto1.29.0-alpineand parameterized the version for flexibility. [1] [2]These changes collectively improve the project's messaging capabilities, keep dependencies up-to-date, and enhance the reliability and maintainability of the build and deployment process.