Add Queue Storage DI tests #40

gimlichael · 2025-09-10T20:35:35Z

Summary

test dependency injection bindings for Azure Queue Storage command queue and event bus, with and without markers

Testing

dotnet test test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests.csproj --collect:"XPlat Code Coverage" --results-directory coverage --no-build --verbosity minimal

https://chatgpt.com/codex/tasks/task_e_68c1c7ccf40c8330a1d8efbfe141bce2

Summary by CodeRabbit

Tests
- Added a comprehensive test suite for QueueStorage dependency injection covering command queues and event buses, including marker-based scenarios.
- Verifies service registrations, options configuration delegates, and serializer selection across Newtonsoft.Json and System.Text.Json paths.
- Improves reliability and guards against regressions in Azure QueueStorage integrations.
Chores
- Introduced a dedicated test project and minimal marker types to support the new tests.

coderabbitai · 2025-09-10T20:35:42Z

Walkthrough

Adds a new test project with DI integration tests for Azure Queue Storage components. Introduces two empty marker structs for generic registrations. Tests verify service registrations, generic marker variants, and options delegates for AzureCommandQueue and AzureEventBus using both Newtonsoft.Json and System.Text.Json marshallers.

Changes

Cohort / File(s)	Summary
Test markers `test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Assets/BusMarker.cs`, `test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Assets/QueueMarker.cs`	Add empty public structs `BusMarker` and `QueueMarker` in Assets namespace for generic DI registrations.
ServiceCollection DI tests `test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/ServiceCollectionExtensionsTest.cs`	Add tests asserting DI registrations and resolutions for AzureCommandQueue and AzureEventBus (non-generic and marker-generic), plus options delegate equivalence checks and marshaller usage.
Test project setup `test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests.csproj`	Add test project file, root namespace, project references to core libraries, and include Assets folder.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Test
  participant DI as ServiceCollection
  participant Prov as ServiceProvider
  participant CQ as AzureCommandQueue / AzureCommandQueue<TMarker>
  participant EB as AzureEventBus / AzureEventBus<TMarker>

  Note over Dev,DI: Register command queue
  Dev->>DI: AddAzureCommandQueue(azureSetup)
  DI-->>DI: Register IPointToPointChannel/I(S/R) for ICommand -> CQ
  DI-->>DI: Store AzureQueueOptions delegate

  Note over Dev,DI: Register event bus
  Dev->>DI: AddAzureEventBus(eventBusSetup)
  DI-->>DI: Register IPubSub/I(Pub/Sub) for IIntegrationEvent -> EB
  DI-->>DI: Store EventBusOptions delegate

  Dev->>DI: BuildServiceProvider()
  DI-->>Dev: Prov

  Dev->>Prov: GetService(IPointToPointChannel<ICommand>[, TMarker])
  Prov-->>Dev: CQ instance

  Dev->>Prov: GetService(IPublishSubscribeChannel<IIntegrationEvent>[, TMarker])
  Prov-->>Dev: EB instance

  Note over Dev: Assert types and option delegate equivalence

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Add Queue Storage DI tests" is concise and accurately reflects the primary change in the PR (adding dependency-injection tests for queue storage), matching the PR objectives and the added test files. It is specific enough for a reviewer to understand the main intent while remaining brief.

Poem

I twitch my nose at queues and bus,
New markers hop—no extra fuss.
The tests all nibble DI’s greens,
Ensuring options match the means.
With JSON crunch and tidy routes,
I thump approval: all checks out. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch codex/improve-test-coverage-for-repository

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-09-10T20:52:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.92%. Comparing base (52b1264) to head (287b4bf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   77.82%   78.92%   +1.10%     
==========================================
  Files         177      177              
  Lines        3711     3711              
  Branches      365      365              
==========================================
+ Hits         2888     2929      +41     
+ Misses        821      780      -41     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-09-10T20:53:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (4)

test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Assets/QueueMarker.cs (1)

3-5: Make the marker immutable and add XML docs.

Prevents accidental mutation and aligns with repo doc-comment guidelines.

 namespace Savvyio.Extensions.DependencyInjection.QueueStorage.Assets
 {
-    public struct QueueMarker
-    {
-    }
+    /// <summary>
+    /// Marker type used to differentiate generic DI registrations in tests.
+    /// </summary>
+    public readonly struct QueueMarker
+    {
+    }
 }

test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests.csproj (1)

11-12: Remove redundant folder include.

MSBuild includes folders implicitly; this entry is unnecessary noise.
-  <ItemGroup>
-    <Folder Include="Assets\" />
-  </ItemGroup>

test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Assets/BusMarker.cs (1)

3-5: Mirror QueueMarker: make readonly and document.

Consistent, immutable marker with XML docs.

 namespace Savvyio.Extensions.DependencyInjection.QueueStorage.Assets
 {
-    public struct BusMarker
-    {
-    }
+    /// <summary>
+    /// Marker type used to differentiate generic DI registrations for event bus in tests.
+    /// </summary>
+    public readonly struct BusMarker
+    {
+    }
 }

test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/ServiceCollectionExtensionsTest.cs (1)

43-43: Enable DI validation and assert marshaller type.

Catches misconfigured registrations early and verifies the intended marshaller is wired.

-            var provider = services.BuildServiceProvider();
+            using var provider = services.BuildServiceProvider(new ServiceProviderOptions
+            {
+                ValidateOnBuild = true,
+                ValidateScopes = true
+            });
+            Assert.IsType<NewtonsoftJsonMarshaller>(provider.GetRequiredService<IMarshaller>());

-            var provider = services.BuildServiceProvider();
+            using var provider = services.BuildServiceProvider(new ServiceProviderOptions
+            {
+                ValidateOnBuild = true,
+                ValidateScopes = true
+            });
+            Assert.IsType<JsonMarshaller>(provider.GetRequiredService<IMarshaller>());

-            var provider = services.BuildServiceProvider();
+            using var provider = services.BuildServiceProvider(new ServiceProviderOptions
+            {
+                ValidateOnBuild = true,
+                ValidateScopes = true
+            });
+            Assert.IsType<NewtonsoftJsonMarshaller>(provider.GetRequiredService<IMarshaller>());

-            var provider = services.BuildServiceProvider();
+            using var provider = services.BuildServiceProvider(new ServiceProviderOptions
+            {
+                ValidateOnBuild = true,
+                ValidateScopes = true
+            });
+            Assert.IsType<JsonMarshaller>(provider.GetRequiredService<IMarshaller>());

Also applies to: 76-76, 114-114, 161-161

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52b1264 and 287b4bf.

📒 Files selected for processing (4)

test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Assets/BusMarker.cs (1 hunks)
test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Assets/QueueMarker.cs (1 hunks)
test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests.csproj (1 hunks)
test/Savvyio.Extensions.DependencyInjection.QueueStorage.Tests/ServiceCollectionExtensionsTest.cs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (7)

test/**