Expand messaging extension test coverage #41

gimlichael · 2025-09-11T00:03:17Z

Summary

Add missing unit tests for SQS client configuration, ARN conversion, visibility timeout clamping
Cover edge cases for NATS command queue heartbeat override
Verify RabbitMQ connectivity initialization is thread-safe

Testing

for proj in $(find test -name '*.csproj' | grep -v FunctionalTests); do dotnet test $proj; done

https://chatgpt.com/codex/tasks/task_e_68c1e1e6cc5c83308a173cdc61ea3b36

Summary by CodeRabbit

Tests
- Expanded coverage across messaging integrations.
  - NATS: Confirms heartbeat can be overridden after expiry settings.
  - RabbitMQ: Verifies thread-safe connectivity initialization under concurrent calls.
  - Amazon SQS: Ensures visibility timeout clamps to allowed limits.
  - AWS client configuration: Validates and resolves SQS/SNS configurations correctly.
  - SNS: Confirms string-to-ARN helper builds correct ARNs with defaults and custom options.

coderabbitai · 2025-09-11T00:03:26Z

Walkthrough

Adds new unit tests across NATS, RabbitMQ, and AWS SQS-related components: a NATS heartbeat override test, a RabbitMQ connectivity thread-safety test, SQS visibility timeout clamping test, SQS client config extension tests, and SNS URI string extension tests. No production code changes.

Changes

Cohort / File(s)	Summary
NATS Command Queue Options Tests `test/Savvyio.Extensions.NATS.Tests/Commands/NatsCommandQueueOptionsTest.cs`	Adds Heartbeat_Can_Be_Overridden_After_Expires test validating default heartbeat from Expires and manual override behavior.
RabbitMQ Connectivity Thread-Safety Tests `test/Savvyio.Extensions.RabbitMQ.Tests/RabbitMqMessageTest.cs`	Adds EnsureConnectivityAsync_IsThreadSafe_WhenCalledConcurrently test to assert single connection initialization under concurrent calls using mocks and reflection.
AWS SQS/SNS Extensions Tests `test/Savvyio.Extensions.SimpleQueueService.Tests/AmazonMessageReceiveOptionsTest.cs`, `test/Savvyio.Extensions.SimpleQueueService.Tests/ClientConfigExtensionsTest.cs`, `test/Savvyio.Extensions.SimpleQueueService.Tests/EventDriven/StringExtensionsTest.cs`	Adds tests for SQS visibility timeout clamping; ClientConfig extensions validation and resolution; string ToSnsUri default and custom ARN construction.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant T as Test
  participant R as RabbitMqMessage
  participant F as IConnectionFactory (mock)
  participant C as IConnection (mock)
  participant CH as IChannel (mock)

  Note over T,R: Concurrent initialization
  T->>R: EnsureConnectivityAsync()
  par Concurrent call
    T->>R: EnsureConnectivityAsync()
  and
    T->>R: EnsureConnectivityAsync()
  end

  alt First initialization path
    R->>F: CreateConnectionAsync()
    F-->>R: C
    R->>C: CreateChannelAsync()
    C-->>R: CH
    R-->>T: Completed
  else Already initialized
    R-->>T: Completed (no new connection)
  end

  Note over F: Verify called exactly once

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

V4.1.0/support for rabbitmq #35 — Introduces RabbitMQ support; directly related to the new test validating thread-safe connectivity initialization.

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Expand messaging extension test coverage" succinctly and accurately reflects the primary change — adding unit tests to expand coverage for messaging-related extensions (SQS/SNS, NATS, RabbitMQ and related helpers). It is concise, on-topic, and readable for reviewers scanning history.

Poem

A thump of paws, a twitching nose,
I test the queues where traffic flows.
NATS beats steady, Rabbit hops in sync,
SQS keeps time—no overflow brink.
SNS sings ARNs so neat—
All green lights now, my work complete! 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch codex/improve-test-coverage-for-extensions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (3)

test/Savvyio.Extensions.SimpleQueueService.Tests/AmazonMessageReceiveOptionsTest.cs (1)

49-59: Good clamp coverage; add boundary asserts inline.

Nice edge coverage. Add explicit boundary checks for 0s and exactly Max to prevent regressions.

Apply this diff:

         [Fact]
         public void VisibilityTimeout_ShouldClampValue_WhenOutsideRangeOfAllowedLimits()
         {
             var sut = new AmazonMessageReceiveOptions();

             sut.VisibilityTimeout = TimeSpan.MinValue;
             Assert.Equal(TimeSpan.Zero, sut.VisibilityTimeout);
+            
+            // Lower boundary exact
+            sut.VisibilityTimeout = TimeSpan.Zero;
+            Assert.Equal(TimeSpan.Zero, sut.VisibilityTimeout);

             sut.VisibilityTimeout = TimeSpan.FromSeconds(AmazonMessageOptions.MaxVisibilityTimeoutInSeconds + 1);
             Assert.Equal(TimeSpan.FromSeconds(AmazonMessageOptions.MaxVisibilityTimeoutInSeconds), sut.VisibilityTimeout);
+            
+            // Upper boundary exact
+            sut.VisibilityTimeout = TimeSpan.FromSeconds(AmazonMessageOptions.MaxVisibilityTimeoutInSeconds);
+            Assert.Equal(TimeSpan.FromSeconds(AmazonMessageOptions.MaxVisibilityTimeoutInSeconds), sut.VisibilityTimeout);
         }

test/Savvyio.Extensions.NATS.Tests/Commands/NatsCommandQueueOptionsTest.cs (1)

72-82: Override behavior looks correct; strengthen with persistence check.

After manual override, ensure subsequent Expires updates don’t reset Heartbeat.

Apply this diff:

         public void Heartbeat_Can_Be_Overridden_After_Expires()
         {
             var options = new NatsCommandQueueOptions();

             options.Expires = TimeSpan.FromSeconds(60);
             Assert.Equal(TimeSpan.FromSeconds(5), options.Heartbeat);

             options.Heartbeat = TimeSpan.FromSeconds(15);
             Assert.Equal(TimeSpan.FromSeconds(15), options.Heartbeat);
+            
+            // Verify override persists even if Expires changes again
+            options.Expires = TimeSpan.FromSeconds(45);
+            Assert.Equal(TimeSpan.FromSeconds(15), options.Heartbeat);
         }

test/Savvyio.Extensions.SimpleQueueService.Tests/ClientConfigExtensionsTest.cs (1)

14-25: Solid validity checks.

Covers null, happy path, and wrong length. Consider adding a case with unrelated configs to assert false.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52b1264 and db6d8eb.

📒 Files selected for processing (5)

test/Savvyio.Extensions.NATS.Tests/Commands/NatsCommandQueueOptionsTest.cs (1 hunks)
test/Savvyio.Extensions.RabbitMQ.Tests/RabbitMqMessageTest.cs (1 hunks)
test/Savvyio.Extensions.SimpleQueueService.Tests/AmazonMessageReceiveOptionsTest.cs (1 hunks)
test/Savvyio.Extensions.SimpleQueueService.Tests/ClientConfigExtensionsTest.cs (1 hunks)
test/Savvyio.Extensions.SimpleQueueService.Tests/EventDriven/StringExtensionsTest.cs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

**/*Test.cs