-
Notifications
You must be signed in to change notification settings - Fork 5
V5.0.0/dotnet ten launch #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 104 files out of 211 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project to .NET 10 (LTS) while removing .NET 8 support, aligning with the project's strategy to target only the latest LTS, STS, and cross-platform .NET versions. The changes comprehensively update dependencies, testing infrastructure, CI/CD workflows, and documentation.
Key changes:
- Migration from .NET 8/9 to .NET 9/10 target frameworks
- Upgrade to xUnit v3 with updated test ordering attributes
- Dependency version updates across all packages
- CI/CD workflow updates to latest reusable job versions
Reviewed Changes
Copilot reviewed 209 out of 211 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Updated target frameworks from net8.0/net9.0 to net9.0/net10.0, added xUnit v3 testing platform configuration |
| Directory.Packages.props | Updated all package dependencies, added conditional System.Linq.Async for .NET 9, migrated to xUnit v3 packages |
| test/**/*.cs | Removed unused Xunit.Abstractions imports, migrated from Xunit.Priority to Xunit.v3.Priority with updated TestCaseOrderer syntax |
| src/Savvyio.Messaging/*.csproj | Added conditional System.Linq.Async package reference for .NET 9 |
| .github/workflows/pipelines.yml | Updated all reusable workflow references to latest major versions (v3 for most, v2 for nuget-push) |
| .nuget/**/PackageReleaseNotes.txt | Added version 5.0.0 release notes documenting .NET 10 support and .NET 8 removal |
| .nuget/**/README.md | Updated availability messaging from .NET 8/9 to .NET 9/10 |
| README.md | Restructured documentation with improved organization and updated .NET version references |
| .docfx/docfx.json | Updated TargetFramework from net9.0 to net10.0 for documentation generation |
| .docfx/Dockerfile.docfx | Updated nginx base image from 1.29.1 to 1.29.3-alpine |
| CHANGELOG.md | Added version 5.0.0 entry documenting the .NET 10 migration |
| testenvironments.json | Updated Docker test runner image to include .NET 10 SDK |
… .NET 10 changes from Microsoft
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 79.11% 79.11%
=======================================
Files 177 177
Lines 3711 3711
Branches 365 365
=======================================
Hits 2936 2936
Misses 774 774
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|

This pull request introduces major updates to support .NET 10 across the codebase, removes support for .NET 8, upgrades dependencies, and updates CI/CD workflows to use the latest reusable jobs. The documentation and release notes have also been revised to reflect these changes, ensuring clarity for users and maintainers.
.NET Target Framework Migration
.docfx/docfx.jsonfromnet9.0tonet10.0for both main and extension APIs. [1] [2]Dependency and Docker Updates
.docfx/Dockerfile.docfxto usenginx:1.29.3-alpinefor improved stability and security.CI/CD Workflow Improvements
.github/workflows/pipelines.ymlto use the latest major versions (@v3or@v2) for build, pack, test, install-dotnet, SonarCloud, CodeQL, and NuGet push steps, ensuring compatibility with .NET 10 and benefiting from upstream improvements. [1] [2] [3] [4] [5] [6] [7] [8]Documentation Updates
.NET 9and.NET 10, replacing outdated banners and availability notes. [1] [2] [3] [4] [5] [6] [7]5.0.0, .NET 10 availability, and dependency changes. [1] [2] [3] [4] [5] [6] [7] [8]These changes ensure the project is up-to-date with the latest .NET ecosystem and provide clear guidance and compatibility for users and contributors.