Skip to content

Conversation

@gimlichael
Copy link
Member

This pull request introduces major updates to support .NET 10 across the codebase, removes support for .NET 8, upgrades dependencies, and updates CI/CD workflows to use the latest reusable jobs. The documentation and release notes have also been revised to reflect these changes, ensuring clarity for users and maintainers.

.NET Target Framework Migration

  • Added support for .NET 10 (LTS) and removed support for .NET 8 (LTS) in all relevant package release notes and documentation files, ensuring the project is aligned with the latest .NET versions. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Updated target framework properties in .docfx/docfx.json from net9.0 to net10.0 for both main and extension APIs. [1] [2]

Dependency and Docker Updates

  • Upgraded dependencies to the latest compatible versions for all supported target frameworks, as noted in package release notes. [1] [2] [3] [4] [5] [6] [7]
  • Updated the base image in .docfx/Dockerfile.docfx to use nginx:1.29.3-alpine for improved stability and security.

CI/CD Workflow Improvements

  • Migrated all reusable workflow jobs in .github/workflows/pipelines.yml to use the latest major versions (@v3 or @v2) for build, pack, test, install-dotnet, SonarCloud, CodeQL, and NuGet push steps, ensuring compatibility with .NET 10 and benefiting from upstream improvements. [1] [2] [3] [4] [5] [6] [7] [8]

Documentation Updates

  • Revised all package and project README files to highlight support for .NET 9 and .NET 10, replacing outdated banners and availability notes. [1] [2] [3] [4] [5] [6] [7]
  • Updated release notes in all affected packages to reflect new version 5.0.0, .NET 10 availability, and dependency changes. [1] [2] [3] [4] [5] [6] [7] [8]

These changes ensure the project is up-to-date with the latest .NET ecosystem and provide clear guidance and compatibility for users and contributors.

@gimlichael gimlichael requested a review from Copilot November 15, 2025 04:15
@gimlichael gimlichael self-assigned this Nov 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 15, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

104 files out of 211 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v5.0.0/dotnet-ten-launch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project to .NET 10 (LTS) while removing .NET 8 support, aligning with the project's strategy to target only the latest LTS, STS, and cross-platform .NET versions. The changes comprehensively update dependencies, testing infrastructure, CI/CD workflows, and documentation.

Key changes:

  • Migration from .NET 8/9 to .NET 9/10 target frameworks
  • Upgrade to xUnit v3 with updated test ordering attributes
  • Dependency version updates across all packages
  • CI/CD workflow updates to latest reusable job versions

Reviewed Changes

Copilot reviewed 209 out of 211 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Directory.Build.props Updated target frameworks from net8.0/net9.0 to net9.0/net10.0, added xUnit v3 testing platform configuration
Directory.Packages.props Updated all package dependencies, added conditional System.Linq.Async for .NET 9, migrated to xUnit v3 packages
test/**/*.cs Removed unused Xunit.Abstractions imports, migrated from Xunit.Priority to Xunit.v3.Priority with updated TestCaseOrderer syntax
src/Savvyio.Messaging/*.csproj Added conditional System.Linq.Async package reference for .NET 9
.github/workflows/pipelines.yml Updated all reusable workflow references to latest major versions (v3 for most, v2 for nuget-push)
.nuget/**/PackageReleaseNotes.txt Added version 5.0.0 release notes documenting .NET 10 support and .NET 8 removal
.nuget/**/README.md Updated availability messaging from .NET 8/9 to .NET 9/10
README.md Restructured documentation with improved organization and updated .NET version references
.docfx/docfx.json Updated TargetFramework from net9.0 to net10.0 for documentation generation
.docfx/Dockerfile.docfx Updated nginx base image from 1.29.1 to 1.29.3-alpine
CHANGELOG.md Added version 5.0.0 entry documenting the .NET 10 migration
testenvironments.json Updated Docker test runner image to include .NET 10 SDK

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.11%. Comparing base (be5a3f2) to head (37ea959).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   79.11%   79.11%           
=======================================
  Files         177      177           
  Lines        3711     3711           
  Branches      365      365           
=======================================
  Hits         2936     2936           
  Misses        774      774           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gimlichael gimlichael merged commit 8a1e386 into main Nov 15, 2025
146 checks passed
@gimlichael gimlichael deleted the v5.0.0/dotnet-ten-launch branch November 15, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants