V9.0.3/package maintenance #8
Conversation
WalkthroughThis update upgrades several dependencies and Docker images to newer versions, refactors the GitHub Actions pipeline to use reusable workflows, and documents these changes in release notes and the changelog. Test environment Docker tags are also updated. No functional code changes or public API modifications are included. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Reusable Workflows
Developer->>GitHub Actions: Push code
GitHub Actions->>Reusable Workflows: Call build workflow
GitHub Actions->>Reusable Workflows: Call pack workflow (after build)
GitHub Actions->>Reusable Workflows: Call test workflow (after build)
GitHub Actions->>Reusable Workflows: Call deploy workflow (after pack)
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 19 19
Lines 666 666
Branches 51 51
=======================================
Hits 555 555
Misses 110 110
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.docfx/Dockerfile.docfx (1)
11-11: Consider specifying build platform for the final stage.For consistency with the
baseandbuildstages, you may add the--platform=$BUILDPLATFORMflag here:-FROM nginx:1.27.5-alpine AS final +FROM --platform=$BUILDPLATFORM nginx:1.27.5-alpine AS final
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.docfx/Dockerfile.docfx(1 hunks).github/workflows/pipelines.yml(2 hunks).nuget/Codebelt.Unitify/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(1 hunks)testenvironments.json(1 hunks)
🧰 Additional context used
🪛 Hadolint (2.12.0)
.docfx/Dockerfile.docfx
[error] 6-6: Use COPY instead of ADD for files and folders
(DL3020)
🔇 Additional comments (10)
Directory.Packages.props (1)
6-8: Approve package version upgrades.The bumps for Codebelt.Extensions.Xunit.App → 10.0.1, Cuemon.Core → 9.0.5, Microsoft.NET.Test.Sdk → 17.14.0, and xunit.runner.visualstudio → 3.1.0 align with the documented service update and test environment changes.
Also applies to: 14-14
CHANGELOG.md (1)
10-12: Changelog entry for v9.0.3 is accurate and aligns with PR objectives.The new
## [9.0.3] - 2025-05-25section correctly describes this release as a service update focused on package dependencies.testenvironments.json (1)
12-12: Update Docker image tag for Docker-Ubuntu environment.Changing to
gimlichael/ubuntu-testrunner:net8.0.409-9.0.300ensures the test runner matches the updated SDK and dependencies..nuget/Codebelt.Unitify/PackageReleaseNotes.txt (1)
1-5: PackageReleaseNotes updated for v9.0.3 dependencies.The entry clearly states availability on .NET 9/8 and notes that dependencies have been upgraded to the latest compatible versions, matching the PR’s scope.
.docfx/Dockerfile.docfx (2)
1-1: Base stage updated with explicit build platform and nginx version bump.Specifying
--platform=$BUILDPLATFORMand upgrading tonginx:1.27.5-alpinefollows container best practices for multi-arch builds.
4-4: Build stage updated to latest docfx image.Switching to
codebeltnet/docfx:2.78.3keeps the documentation tooling in sync with the project’s DocFX requirements..github/workflows/pipelines.yml (4)
26-34: DRY build job via reusable workflow
Migrating to thecodebeltnet/jobs-dotnet-buildreusable workflow with a job-level matrix forconfigurationremoves inline steps while still covering both Debug and Release builds. Thesecrets: inheritdirective ensures credentials flow through correctly.
37-46: Centralize package job with reusable workflow
Invokingcodebeltnet/jobs-dotnet-packand supplyingupload-packed-artifact: truealongside theversionoutput from the build job aligns with our CI conventions and eliminates duplicated packaging logic.
49-61: Simplify test job by calling reusable workflow
Great refactor to usecodebeltnet/jobs-dotnet-testfor both Ubuntu and Windows matrices. Please verify that thebuild-switchesinput and theruns-on: ${{ matrix.os }}mapping are correctly consumed by the reusable workflow.
90-91: Bring deploy into modern NuGet-push workflow
Switching tocodebeltnet/jobs-nuget-pushand extendingneedsto include all quality-gate jobs (sonarcloud, codecov, codeql) ensures that packages are only published after passing analysis and coverage checks.
|
This pull request includes updates to dependencies, build workflows, and documentation. The most significant changes focus on upgrading package versions, streamlining GitHub Actions workflows, and updating changelogs to reflect the latest service updates.
Dependency Updates:
Directory.Packages.props, includingCodebelt.Extensions.Xunit.Appto10.0.1,Cuemon.Coreto9.0.5, andMicrosoft.NET.Test.Sdkto17.14.0.testenvironments.jsontogimlichael/ubuntu-testrunner:net8.0.409-9.0.300.Build Workflow Improvements:
.github/workflows/pipelines.ymlto use reusable workflows forbuild,pack, andtestjobs, significantly reducing redundancy.nugetjob in.github/workflows/pipelines.ymlto reference thejobs-nuget-pushreusable workflow.Documentation Updates:
9.0.3in.nuget/Codebelt.Unitify/PackageReleaseNotes.txt, highlighting dependency upgrades.CHANGELOG.mdwith an entry for version9.0.3, marking it as a service update focused on package dependencies.Dockerfile Update:
.docfx/Dockerfile.docfxto use platform-specific base and build images and upgraded to the latest versions (nginx:1.27.5-alpineandcodebeltnet/docfx:2.78.3).Summary by CodeRabbit