Skip to content

Add Micro QR code support #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Add Micro QR code support #592

wants to merge 40 commits into from

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Apr 13, 2025

Prerequisites (to reduce diff):

Status:

  • All generated micro QR codes are scannable
  • Most QR codes match the output of the segno python library
  • Need to add tests and validate combinations of lengths, character types, etc

Side notes:

  • ASCII small generator has x/y swapped and prints inverted compared to regular ASCII generator
  • The segno python library does not apply padding properly so micro QR codes consisting mostly of padding don't match

@Shane32
Copy link
Contributor Author

Shane32 commented Apr 14, 2025

M2 codes will generate correctly now

@Shane32
Copy link
Contributor Author

Shane32 commented Apr 16, 2025

Still a little more work to do, but it appears to be generating readable codes for all micro QR code sizes now.

@Shane32 Shane32 marked this pull request as ready for review April 19, 2025 15:30
@Shane32
Copy link
Contributor Author

Shane32 commented Apr 19, 2025

This implementation is complete. I might add some more tests but everything is working.

@gfoidl
Copy link
Contributor

gfoidl commented Apr 23, 2025

I'm looking forward to review the PR, but after #590 got merged so I can focus on the new stuff.

@Shane32 👍🏻 for your work

@codebude
Copy link
Owner

codebude commented Jun 2, 2025

@gfoidl #590 is merged now.

@gfoidl
Copy link
Contributor

gfoidl commented Jun 2, 2025

@Shane32 please merge the master-branch in your micro-branch, so that the latest changes are in and the diff becomes smaller for review 😉. IIRC GitHub doesn't do that automatically.

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 2, 2025

I've merged it, but it looks like the CI scripts are failing again...

Copy link
Contributor

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestion to the code.
For the logic about micro QR code I can't tell very much, here I trust @Shane32.

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 2, 2025

Thanks @gfoidl !

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 13, 2025

CI scripts have been fixed - @codebude can you review?

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 16, 2025

Hey @codebude do you have a little time to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants