Skip to content

Improve waitUrlEquals error message to include actual error #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavertMik merged 4 commits into from
Jan 18, 2026
+27 −21
Merged

Improve waitUrlEquals error message to include actual error #5383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db2bff1
include actual error in waitUrlEquals when URL matches
DenysKuchma Jan 13, 2026
1a8d252
improve waitUrlEquals implementation
DenysKuchma Jan 15, 2026
881ab37
Merge branch '4.x' of https://github.com/codeceptjs/CodeceptJS into b…
DenysKuchma Jan 15, 2026
62ac7b3
fix playwright helper
DenysKuchma Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/helper/Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3557,7 +3557,11 @@ class Playwright extends Helper {
.catch(async e => {
const currUrl = await this._getPageUrl() // Required because the waitForFunction can't return data.
if (/Timeout/i.test(e.message)) {
throw new Error(`expected url to be ${urlPart}, but found ${currUrl}`)
if (urlPart !== currUrl) {
throw new Error(`expected url to be ${urlPart}, but found ${currUrl}`)
} else {
throw new Error(`expected url not loaded, error message: ${e.message}`)
}
} else {
throw e
}
Expand Down
6 changes: 5 additions & 1 deletion lib/helper/Puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,7 +2467,11 @@ class Puppeteer extends Helper {
.catch(async e => {
const currUrl = await this._getPageUrl() // Required because the waitForFunction can't return data.
if (/Waiting failed/i.test(e.message) || /failed: timeout/i.test(e.message)) {
throw new Error(`expected url to be ${urlPart}, but found ${currUrl}`)
if (urlPart !== currUrl) {
throw new Error(`expected url to be ${urlPart}, but found ${currUrl}`)
} else {
throw new Error(`expected url not loaded, error message: ${e.message}`)
}
} else {
throw e
}
Expand Down