Skip to content

fix: pass pull_request_number as keyword arg in empty_upload - #740

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/empty-upload-pr-kwargs
Open

fix: pass pull_request_number as keyword arg in empty_upload#740
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/empty-upload-pr-kwargs

Conversation

@sentry

@sentry sentry Bot commented Jul 26, 2026

Copy link
Copy Markdown

The empty_upload command was calling create_commit_logic with positional arguments. This caused a KeyError: 'pull_request_number' in tests that expected to find pull_request_number in mock.call_args.kwargs.

This change updates the call to create_commit_logic in codecov_cli/commands/empty_upload.py to use explicit keyword arguments for all parameters. This ensures that pull_request_number (and other arguments) are correctly passed as keyword arguments, resolving the KeyError and improving clarity.

Fixes CLI-FH

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
723 1 722 1
View the full list of 1 ❄️ flaky test(s)
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 100.00% (Passed 0 times, Failed 1625 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants