fix: pass pull_request_number as keyword arg in empty_upload - #740
Open
sentry[bot] wants to merge 1 commit into
Open
fix: pass pull_request_number as keyword arg in empty_upload#740sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
empty_uploadcommand was callingcreate_commit_logicwith positional arguments. This caused aKeyError: 'pull_request_number'in tests that expected to findpull_request_numberinmock.call_args.kwargs.This change updates the call to
create_commit_logicincodecov_cli/commands/empty_upload.pyto use explicit keyword arguments for all parameters. This ensures thatpull_request_number(and other arguments) are correctly passed as keyword arguments, resolving theKeyErrorand improving clarity.Fixes CLI-FH