-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only show GH config banner when no welcome banner #3680
Conversation
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3680 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 824 824
Lines 14805 14805
Branches 4210 4210
=======================================
Hits 14625 14625
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3680 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 824 824
Lines 14805 14805
Branches 4210 4202 -8
=======================================
Hits 14625 14625
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3680 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 824 824
Lines 14805 14805
Branches 4202 4210 +8
=======================================
Hits 14625 14625
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3680 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 824 824
Lines 14805 14805
Branches 4210 4210
=======================================
Hits 14625 14625
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
This reverts commit dfb4df6.
Description
Followup PR to the Non-PAT Appless experience to prevent both the blue Welcome banner and blue GH App Install banner don't show at the same time as it overwhelms the user. The GH banner should only come up when the other is not showing.
Code Example
Notable Changes
Screenshots
Problem:
![Screenshot 2025-01-24 at 15 06 06](https://private-user-images.githubusercontent.com/170470397/406597520-4202d555-0089-4583-a4a5-4634f97cd4de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjIxODYsIm5iZiI6MTczODkyMTg4NiwicGF0aCI6Ii8xNzA0NzAzOTcvNDA2NTk3NTIwLTQyMDJkNTU1LTAwODktNDU4My1hNGE1LTQ2MzRmOTdjZDRkZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwOTUxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMjNjYTEyNjFhYzExZjU5Yzc1NmY1MDI1ZTNiYjVhMjc3YjYwOWJlYzU0YjMxOWU0YjI3MTc5MzRiZWVmMGQ2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.B8_5n6GwTbAQmy_fUrSan33dfnEmH7FaytVWaPbeSwQ)
New:
![Screenshot 2025-01-24 at 1 49 16 PM](https://private-user-images.githubusercontent.com/170470397/406597960-e4294d82-ae00-4694-a08d-3bb1e7d29310.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjIxODYsIm5iZiI6MTczODkyMTg4NiwicGF0aCI6Ii8xNzA0NzAzOTcvNDA2NTk3OTYwLWU0Mjk0ZDgyLWFlMDAtNDY5NC1hMDhkLTNiYjFlN2QyOTMxMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwOTUxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYWYzM2NkNDEzY2I5YzU5MWU4MmQ4ZjE4MGFhYTk4ZTljNmQxODQ5NjUwNGNjMTFjMTI2YWFkYWFmMmE5ZDJmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jzWnlyrT8yjKQaK9PqKIaW0t6QBxkSO66kPKZPy3MBM)
![Screenshot 2025-01-24 at 1 49 32 PM](https://private-user-images.githubusercontent.com/170470397/406597979-2d703c27-7a1a-4d76-93a4-48ce1a43d4c2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjIxODYsIm5iZiI6MTczODkyMTg4NiwicGF0aCI6Ii8xNzA0NzAzOTcvNDA2NTk3OTc5LTJkNzAzYzI3LTdhMWEtNGQ3Ni05M2E0LTQ4Y2UxYTQzZDRjMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwOTUxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hZDIwNjQ2ZjdiNzJkYTA4NjY3ODJiOTRjYmNiOTU3MTkzMDAwYjUxNzIxOTdiZWZmZWQ1ZDYxYTBkYmZiYWE4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.aO_1ndTwA3KkIKtYsQYKswQML0Aa9x0qZZLBivr48_0)
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.