Cy/non pat appless 2 #3684
Cy/non pat appless 2 #3684
Conversation
New onboarding container and install codecov modal
Bundle ReportChanges will increase total bundle size by 65.78kB (0.53%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
- Coverage 98.82% 98.79% -0.04%
==========================================
Files 825 824 -1
Lines 14889 14809 -80
Branches 4229 4198 -31
==========================================
- Hits 14714 14630 -84
- Misses 166 170 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
- Coverage 98.82% 98.79% -0.04%
==========================================
Files 825 824 -1
Lines 14889 14809 -80
Branches 4237 4206 -31
==========================================
- Hits 14714 14630 -84
- Misses 166 170 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
- Coverage 98.82% 98.79% -0.04%
==========================================
Files 825 824 -1
Lines 14889 14809 -80
Branches 4229 4206 -23
==========================================
- Hits 14714 14630 -84
- Misses 166 170 +4
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| @@ -52,7 +52,7 @@ export const PlanDataSchema = z | |||
| .object({ | |||
| owner: z | |||
| .object({ | |||
| hasPrivateRepos: z.boolean(), | |||
| hasPrivateRepos: z.boolean().nullish(), | |||
There was a problem hiding this comment.
this field is hasPrivateRepos: Boolean on the Owner graphql type and was causing unrelated zod errors
calvin-codecov
force-pushed
the
cy/non_pat_appless_2
branch
from
fbca66a to
5a43915
Compare
calvin-codecov
force-pushed
the
cy/non_pat_appless_2
branch
from
5a43915 to
b61b646
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
Second attempt at rollout for the appless experience as the original (#3667) was reverted. Also closes https://github.com/codecov/internal-issues/issues/1162. The new changes are after the 7th commit, starting with b61b646.
This PR fixes problem # 2 of the ticket as well as adds more amplitude events. The plan is to monitor DB events coming through checking on users that are created (GH login) vs terms agreed (onboarded).
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.