-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action to do local processing #58
Conversation
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
2 similar comments
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
2 similar comments
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
we are making this change so users don't have to phone home to Codecov. this command will parse the test results files locally and make the Codecov test results comment from the Github Action. Signed-off-by: joseph-sentry <[email protected]>
ac14ed3
to
11e82fe
Compare
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
1 similar comment
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
4 similar comments
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 4 tests with View the full list of failed tests
|
flags: py3.11 # optional | ||
name: codecov-umbrella # optional | ||
token: ${{ secrets.CODECOV_TOKEN }} # required | ||
token: ${{ secrets.CODECOV_GITHUB_TOKEN }} # optional (default = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default I think we call this CODECOV_TOKEN
everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case it's not actually a "codecov token" anymore, it needs to be a github personal access token, "codecov token" usually means then token you can get from the codecov website
Fixes: codecov/engineering-team#1713