Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Updated colors to make text more visible #97

Merged
merged 2 commits into from
Sep 26, 2020

Conversation

gautamkrishnar
Copy link
Contributor

Updated colors according to https://github.com/codeforcauseorg/codeforcause.org/blob/development/design/home_view/home_web.pdf to make text more visible, fixes: #96

Before:
Screenshot 2020-09-25 at 1 03 50 PM

After
Screenshot 2020-09-25 at 1 20 35 PM

@gautamkrishnar gautamkrishnar mentioned this pull request Sep 25, 2020
@Abhishek-kumar09
Copy link
Contributor

How did it looked like this, because in my browser text is written in black.
image

@Abhishek-kumar09
Copy link
Contributor

please give some details so that we can be warned over such issues.

@gautamkrishnar
Copy link
Contributor Author

gautamkrishnar commented Sep 25, 2020

@Abhishek-kumar09 I am using chrome Version 85.0.4183.102 (Official Build) (64-bit) on Mac OS 10.15.6 (19G2021). I suspected it as a CSS issue. Just tested on a windows machine via BrowserStack, looks like it is looking fine on it. Looks weird, let me try to dig deeper into it.

@gautamkrishnar
Copy link
Contributor Author

gautamkrishnar commented Sep 25, 2020

@Abhishek-kumar09 LOL, 😆 I found the issue, by default the font color is white in dark mode (https://material-ui.com/customization/palette/), with the
current implementation:
Current implementation

After setting a static color (PR Preview):
New

You need to enable the mac dark mode to reproduce this.

Please note in the https://github.com/codeforcauseorg/codeforcause.org/blob/development/design/home_view/home_web.pdf the text color is not black.

You guys should also set the color as black at the body level to prevent this issue.

@Abhishek-kumar09
Copy link
Contributor

Nice observation!
The color also looks nice, Initially I applied this view and had set color to the same you did.
Rest to @GangaChatrvedi

@GangaChatrvedi
Copy link
Member

GangaChatrvedi commented Sep 25, 2020

@gautamkrishnar change text colors to black and keep headings as same color you have already done.

@gautamkrishnar
Copy link
Contributor Author

@GangaChatrvedi made the change you requested.

@GangaChatrvedi GangaChatrvedi merged commit da999a6 into codeforcauseorg:development Sep 26, 2020
@gautamkrishnar gautamkrishnar deleted the fix/96 branch September 26, 2020 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text not readable
3 participants