Skip to content

Comments

Fix/cqsh path#2713

Merged
sebjulliand merged 2 commits intocodefori:masterfrom
dcmcdoug:fix/cqsh_path
Jun 6, 2025
Merged

Fix/cqsh path#2713
sebjulliand merged 2 commits intocodefori:masterfrom
dcmcdoug:fix/cqsh_path

Conversation

@dcmcdoug
Copy link
Contributor

@dcmcdoug dcmcdoug commented Jun 5, 2025

The local path used for installing cqsh_1 to an IBM i is missing the api folder.

Changes

Fixed the path to cqsh by adding the missing api folder.

How to test this PR

  1. Remove the $HOME/.vscode/cqsh_1 binary on an IBM i that you will connect to with code for i if it exists.
  2. "Connect and reload server settings" the IBM i through code for i.
  3. Start a PASE terminal with code for i. On the IBM i, $HOME/.vscode/cqsh_1 should get created.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

dcmcdoug added 2 commits June 5, 2025 10:35
The local path used for installing cqsh_1 to an IBM i is missing the api folder.
@worksofliam worksofliam added this to the 2.16.0 milestone Jun 5, 2025
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Jun 6, 2025
Copy link
Member

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @dcmcdoug !
I confirm it fixes the issue.

Before the PR:
image

After the PR:
image

Thank you for your contribution!

@sebjulliand sebjulliand merged commit c388c35 into codefori:master Jun 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants